src/compiler/code-generator.cc - Issue 1514413002: [Interpreter] Generate valid FrameStates in the Bytecode Graph Builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-generator.cc

Issue 1514413002: [Interpreter] Generate valid FrameStates in the Bytecode Graph Builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_materialize_sf

Patch Set: Add checks that environment doesn't change after state nodes are attached Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/code-generator.cc

diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc

index 9ca4f5fafb2124e3981c651a31dfda3f0c6708ad..2aab6823bb267d8007c347d0814aec0065f18819 100644

--- a/src/compiler/code-generator.cc

+++ b/src/compiler/code-generator.cc

@@ -558,6 +558,9 @@ void CodeGenerator::BuildTranslationForFrameStateDescriptor(

static_cast<unsigned int>(descriptor->GetSize(state_combine) -

(1 + descriptor->parameters_count())));

break;

+ case FrameStateType::kInterpretedFunction:

+ // TODO(rmcilroy): Implement interpreted function translation.

+ break;

case FrameStateType::kArgumentsAdaptor:

translation->BeginArgumentsAdaptorFrame(

shared_info_id,

« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | src/compiler/frame-states.h » ('j') | no next file with comments »