Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1514373003: Add test for previously unflattenables (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A tests/FlattenableFactoryToName.cpp View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scroggo
5 years ago (2015-12-11 16:57:46 UTC) #2
hal.canary
lgtm
5 years ago (2015-12-11 17:36:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514373003/1
5 years ago (2015-12-11 18:12:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/061aaa79f7d8a2e93962e8296abaae13f0a7a715
5 years ago (2015-12-11 18:29:07 UTC) #7
scroggo
5 years ago (2015-12-16 22:17:46 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1532753002/ by scroggo@google.com.

The reason for reverting is: Speculative fix for skbug.com/4709.

Powered by Google App Engine
This is Rietveld 408576698