Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: pkg/dart_messages/lib/shared_messages.dart

Issue 1514333002: Add dart_messages package. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add the converted shared_messages.json. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dart_messages/bin/message_id.dart ('k') | pkg/dart_messages/lib/shared_messages.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart_messages/lib/shared_messages.dart
diff --git a/pkg/compiler/lib/src/diagnostics/shared_messages.dart b/pkg/dart_messages/lib/shared_messages.dart
similarity index 90%
rename from pkg/compiler/lib/src/diagnostics/shared_messages.dart
rename to pkg/dart_messages/lib/shared_messages.dart
index 0a4d2ab4d93e5f131a0e59f4a833462ad016c166..bd51f581934a31c2f75267c359de6f5ba33f490e 100644
--- a/pkg/compiler/lib/src/diagnostics/shared_messages.dart
+++ b/pkg/dart_messages/lib/shared_messages.dart
@@ -2,10 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// This file is parsed by JavaScript and must not use fancy Dart constructs.
-// It can contain JSON like constructs and "//" comments (but not "/*" "*/").
-// It must have one assignment (`final MESSAGES =`).
-// All strings must be raw strings.
+// An update to this file must be followed by regenerating the corresponding
+// json file. Use `json_converter.dart` in the bin directory.
+//
+// Every message in this file must have an id. Use `message_id.dart` in the
+// bin directory to generate a fresh one.
// The messages in this file should meet the following guide lines:
//
@@ -57,5 +58,5 @@
// 1. what is wrong, 2. why is it wrong, 3. how do I fix it. However, we
// combine the first two in [template] and the last in [howToFix].
-final MESSAGES = {
+final Map<String, Map> MESSAGES = {
};
« no previous file with comments | « pkg/dart_messages/bin/message_id.dart ('k') | pkg/dart_messages/lib/shared_messages.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698