Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1514323002: [tubofan] Remove .dot output of --trace-turbo (Closed)

Created:
5 years ago by danno
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tubofan] Remove .dot output of --trace-turbo Committed: https://crrev.com/bf24486b22258582e7314832878cc59cd5c9d595 Cr-Commit-Position: refs/heads/master@{#32813}

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Patch Set 3 : Fix tests #

Patch Set 4 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -208 lines) Patch
M src/compiler/graph-visualizer.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +0 lines, -184 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 1 2 5 chunks +0 lines, -5 lines 0 comments Download
M test/unittests/compiler/control-equivalence-unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
danno
PTAL
5 years ago (2015-12-11 07:25:22 UTC) #2
Benedikt Meurer
lgtm
5 years ago (2015-12-11 07:37:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514323002/1
5 years ago (2015-12-11 08:03:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/7681) v8_linux_rel on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-11 08:05:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514323002/20001
5 years ago (2015-12-11 16:07:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/8091)
5 years ago (2015-12-11 16:11:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514323002/60001
5 years ago (2015-12-11 16:17:12 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-11 16:58:07 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-11 16:58:40 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/bf24486b22258582e7314832878cc59cd5c9d595
Cr-Commit-Position: refs/heads/master@{#32813}

Powered by Google App Engine
This is Rietveld 408576698