Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart

Issue 1514263004: extract LabelContributor from local reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/test_all.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
index 700f414a015758b255ba199da2da7ffe0e4a4878..1c80727f60b51eeab103861d5f883d4483533b7c 100644
--- a/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
@@ -174,7 +174,7 @@ void main() {
''');
expect(computeFast(), isTrue);
// Labels in outer functions are never accessible.
- assertSuggestLabel('bar');
+ assertNotSuggested('bar');
assertNotSuggested('foo');
}
@@ -190,7 +190,7 @@ void main() {
''');
expect(computeFast(), isTrue);
// Labels in outer functions are never accessible.
- assertSuggestLabel('bar');
+ assertNotSuggested('bar');
assertNotSuggested('foo');
}
@@ -234,8 +234,8 @@ void main() {
}
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
- assertSuggestLabel('bar');
+ assertNotSuggested('foo');
+ assertNotSuggested('bar');
}
test_constructor_parameters_mixed_required_and_named() {
@@ -290,9 +290,9 @@ void main() {
}
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
- assertSuggestLabel('bar');
- assertSuggestLabel('baz');
+ assertNotSuggested('foo');
+ assertNotSuggested('bar');
+ assertNotSuggested('baz');
}
test_continue_from_switch_to_loop() {
@@ -307,7 +307,7 @@ void main() {
}
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
+ assertNotSuggested('foo');
}
test_continue_ignores_outer_functions_using_closure_with_loop() {
@@ -322,7 +322,7 @@ void main() {
''');
expect(computeFast(), isTrue);
// Labels in outer functions are never accessible.
- assertSuggestLabel('bar');
+ assertNotSuggested('bar');
assertNotSuggested('foo');
}
@@ -339,7 +339,7 @@ void main() {
''');
expect(computeFast(), isTrue);
// Labels in outer functions are never accessible.
- assertSuggestLabel('bar');
+ assertNotSuggested('bar');
assertNotSuggested('foo');
}
@@ -355,7 +355,7 @@ void main() {
''');
expect(computeFast(), isTrue);
// Labels in outer functions are never accessible.
- assertSuggestLabel('bar');
+ assertNotSuggested('bar');
assertNotSuggested('foo');
}
@@ -372,7 +372,7 @@ void main() {
''');
expect(computeFast(), isTrue);
// Labels in outer functions are never accessible.
- assertSuggestLabel('bar');
+ assertNotSuggested('bar');
assertNotSuggested('foo');
}
@@ -404,7 +404,7 @@ void main() {
break;
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
+ assertNotSuggested('foo');
}
test_continue_to_enclosing_loop() {
@@ -418,8 +418,8 @@ void main() {
}
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
- assertSuggestLabel('bar');
+ assertNotSuggested('foo');
+ assertNotSuggested('bar');
}
test_continue_to_enclosing_switch() {
@@ -440,9 +440,9 @@ void main() {
}
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
- assertSuggestLabel('bar');
- assertSuggestLabel('baz');
+ assertNotSuggested('foo');
+ assertNotSuggested('bar');
+ assertNotSuggested('baz');
}
test_continue_to_later_case() {
@@ -457,7 +457,7 @@ void main() {
break;
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
+ assertNotSuggested('foo');
}
test_continue_to_same_case() {
@@ -472,7 +472,7 @@ void main() {
break;
''');
expect(computeFast(), isTrue);
- assertSuggestLabel('foo');
+ assertNotSuggested('foo');
}
test_enum() {
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/test_all.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698