Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1514263004: extract LabelContributor from local reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
index a635b8cd76d4e0c0c120a3cfb1439cd32328476c..6b7e04fa37f2bd0f25a76060ce27f6c63246b0bf 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
@@ -119,9 +119,7 @@ class DartCompletionRequestImpl extends CompletionRequestImpl
@override
bool get includeIdentifiers {
- if (_opType == null) {
- _opType = new OpType.forCompletion(target, offset);
- }
+ opType; // <<< ensure _opType is initialized
return !_opType.isPrefixed &&
(_opType.includeReturnValueSuggestions ||
_opType.includeTypeNameSuggestions ||
@@ -152,6 +150,14 @@ class DartCompletionRequestImpl extends CompletionRequestImpl
return _objectType;
}
+ // For internal use only
+ OpType get opType {
+ if (_opType == null) {
+ _opType = new OpType.forCompletion(target, offset);
+ }
+ return _opType;
+ }
+
@override
Future<List<Directive>> resolveDirectives() async {
CompilationUnit libUnit;

Powered by Google App Engine
This is Rietveld 408576698