Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1514253003: Converter update for Big5, KOI8-U and timezone update to 2015g (Closed)

Created:
5 years ago by jungshik at Google
Modified:
5 years ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converter update for Big5, KOI8-U and timezone update to 2015g * Big5 : https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878 Special case the following four more code points in addition to U+5341, U+5345 that are already special cased. U+2550, U+255E, U+2561, U+256A For those 6 code points, the last pointer instead of the first pointer in index-big5.txt is used for round-trip. The first pointer is for decoding-only. * KOI8-U ( https://www.w3.org/Bugs/Public/show_bug.cgi?id=17053 ) - 0xAE and 0xBE are mapped to U+04[50]E instead of U+255[DC]. - Add an alias KOI8-RU BUG=544228 TEST=1. http://goo.gl/reGQPU : encoding(form) test 2. Layout test: fast/encoding/* R=jsbell@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/8d342a405be5ae8aacb1e16f0bc31c3a4fbf26a2

Patch Set 1 #

Patch Set 2 : icu data updated #

Patch Set 3 : readme update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1353 lines, -1322 lines) Patch
M README.chromium View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M android/icudtl.dat View 1 2 Binary file 0 comments Download
M scripts/big5_gen.sh View 2 2 chunks +6 lines, -3 lines 0 comments Download
M source/data/in/icudtl.dat View 1 2 Binary file 0 comments Download
M source/data/mappings/big5-html.ucm View 2 3 chunks +8 lines, -8 lines 0 comments Download
M source/data/mappings/convrtrs.txt View 2 1 chunk +1 line, -0 lines 0 comments Download
M source/data/mappings/koi8-u-html.ucm View 2 4 chunks +2 lines, -2 lines 0 comments Download
M source/data/misc/metaZones.txt View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M source/data/misc/timezoneTypes.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M source/data/misc/windowsZones.txt View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 1 2 152 chunks +1316 lines, -1304 lines 0 comments Download
M windows/icudt.dll View 1 2 Binary file 0 comments Download

Messages

Total messages: 7 (4 generated)
jungshik at Google
Hi, Joshua Can you take a look? Thanks
5 years ago (2015-12-14 21:58:14 UTC) #4
jsbell
lgtm
5 years ago (2015-12-14 22:12:47 UTC) #5
jungshik at Google
5 years ago (2015-12-14 22:32:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as
8d342a405be5ae8aacb1e16f0bc31c3a4fbf26a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698