Remove check for invisible subtrees in LayoutGeometryMap.

Remove check for invisible subtrees in LayoutGeometryMap.

It was added in https://codereview.chromium.org/27104002 to fix a problem wherein
some layer positions were not calculated in PaintLayer because of invisibility.

The code has changed a lot in PaintLayer and in compositing (for the better) since
then. I don't think this is necessary, and it's causing a lifecycle violation
assert elsewhere.

BUG=566936
Committed: https://crrev.com/19a84549ad0bec1308b768f96b2345d4431a8a30
Cr-Commit-Position: refs/heads/master@{#365303}

[chrishtr, 2015-12-11 23:13:28]

Description was changed from

==========
none

BUG=
==========

to

==========
Remove check for invisible subtrees in LayoutGeometryMap.

It was added in https://codereview.chromium.org/27104002 to fix a problem
wherein
some layer positions were not calculated in PaintLayer because of invisibility.

The code has changed a lot in PaintLayer and in compositing (for the better)
since
then. I don't think this is necessary, and it's causing a lifecycle violation
assert elsewhere.

BUG=566936
==========

[chrishtr, 2015-12-14 17:41:14]

chrishtr@chromium.org changed reviewers:
+ jchaffraix@chromium.org

[Julien - ping for review, 2015-12-14 19:54:59]

> it's causing a lifecycle violation assert elsewhere.

Trying to understand this from the description, does that mean that we do
compute the bounds for invisible layers now or that we have another ASSERTs
taking care of it? Also which ASSERT are we talking about?

[chrishtr, 2015-12-14 20:08:01]

On 2015/12/14 at 19:54:59, jchaffraix wrote:
> > it's causing a lifecycle violation assert elsewhere.
> 
> Trying to understand this from the description, does that mean that we do
compute the bounds for invisible layers now or that we have another ASSERTs
taking care of it? Also which ASSERT are we talking about?

As far as I can tell, PaintLayer::updateLayerPositionsAfter* no longer early-out
for invisible children.

The ASSERT leading to this patch is that invisibility depends on compositing
state, which is being violated here. The ASSERT which should now be safe for
invisible children is the one on line 145 of this file.

[Julien - ping for review, 2015-12-14 23:49:09]

Thanks for the explanations, lgtm

[chrishtr, 2015-12-15 00:10:41]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-12-15 00:13:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514243004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514243004/20001

[commit-bot: I haz the power, 2015-12-15 04:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 04:20:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[chrishtr, 2015-12-15 17:56:40]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-12-15 17:57:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514243004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514243004/20001

[commit-bot: I haz the power, 2015-12-15 19:07:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 19:09:15]

Description was changed from

==========
Remove check for invisible subtrees in LayoutGeometryMap.

It was added in https://codereview.chromium.org/27104002 to fix a problem
wherein
some layer positions were not calculated in PaintLayer because of invisibility.

The code has changed a lot in PaintLayer and in compositing (for the better)
since
then. I don't think this is necessary, and it's causing a lifecycle violation
assert elsewhere.

BUG=566936
==========

to

==========
Remove check for invisible subtrees in LayoutGeometryMap.

It was added in https://codereview.chromium.org/27104002 to fix a problem
wherein
some layer positions were not calculated in PaintLayer because of invisibility.

The code has changed a lot in PaintLayer and in compositing (for the better)
since
then. I don't think this is necessary, and it's causing a lifecycle violation
assert elsewhere.

BUG=566936

Committed: https://crrev.com/19a84549ad0bec1308b768f96b2345d4431a8a30
Cr-Commit-Position: refs/heads/master@{#365303}
==========

[commit-bot: I haz the power, 2015-12-15 19:09:16]

Patchset 2 (id:??) landed as
https://crrev.com/19a84549ad0bec1308b768f96b2345d4431a8a30
Cr-Commit-Position: refs/heads/master@{#365303}