Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1514233003: Make assignedSlot return null for a slot in a closed shadow tree (Closed)

Created:
5 years ago by hayato
Modified:
5 years ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v1-slots
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make assignedSlot return null for a slot in a closed shadow tree The spec is http://w3c.github.io/webcomponents/spec/shadow/#widl-NonDocumentTypeChildNode-assignedSlot BUG=531990 Committed: https://crrev.com/1a4253f3f30b7d4a8bc178e1281b62557d7cd85b Cr-Commit-Position: refs/heads/master@{#364961}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html View 1 chunk +56 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514233003/1
5 years ago (2015-12-11 08:43:47 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 10:24:17 UTC) #5
hayato
rebased
5 years ago (2015-12-11 11:09:07 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514233003/20001
5 years ago (2015-12-11 11:09:33 UTC) #8
hayato
PTAL
5 years ago (2015-12-11 11:10:51 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 13:28:38 UTC) #13
kochi
lgtm
5 years ago (2015-12-11 23:31:32 UTC) #14
tkent
lgtm
5 years ago (2015-12-13 23:36:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514233003/20001
5 years ago (2015-12-14 01:08:26 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 03:30:01 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-14 03:31:41 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1a4253f3f30b7d4a8bc178e1281b62557d7cd85b
Cr-Commit-Position: refs/heads/master@{#364961}

Powered by Google App Engine
This is Rietveld 408576698