Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1514183002: Revert "Create direct write font proxy classes and unit tests." (Closed)

Created:
5 years ago by Marijn Kruisselbrink
Modified:
5 years ago
Reviewers:
Ilya Kulshin
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Create direct write font proxy classes and unit tests." This reverts commit 772bb2e55ce932909dc9ac934eabb4c47dd638d4. This CL still causes content_unittests failures. Please make sure they are fixed before relanding.... BUG=525142 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kulshin@chromium.org Committed: https://crrev.com/149da73d46e1e14c6cf904a219a2128b5ec63017 Cr-Commit-Position: refs/heads/master@{#364488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2458 lines) Patch
D content/browser/renderer_host/dwrite_font_proxy_message_filter_win.h View 1 chunk +0 lines, -65 lines 0 comments Download
D content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc View 1 chunk +0 lines, -345 lines 0 comments Download
D content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D content/child/dwrite_font_proxy/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.h View 1 chunk +0 lines, -30 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_win.h View 1 chunk +0 lines, -202 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc View 1 chunk +0 lines, -514 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc View 1 chunk +0 lines, -375 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_localized_strings_win.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/child/dwrite_font_proxy/dwrite_localized_strings_win.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -4 lines 0 comments Download
D content/common/dwrite_font_proxy_messages.h View 1 chunk +0 lines, -39 lines 0 comments Download
M content/common/font_warmup_win.h View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/font_warmup_win.cc View 2 chunks +50 lines, -50 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
D content/test/dwrite_font_fake_sender_win.h View 1 chunk +0 lines, -160 lines 0 comments Download
D content/test/dwrite_font_fake_sender_win.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -43 lines 0 comments Download
M ui/gfx/win/direct_write.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 3 chunks +13 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514183002/1
5 years ago (2015-12-10 21:49:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 21:52:39 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-10 21:53:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/149da73d46e1e14c6cf904a219a2128b5ec63017
Cr-Commit-Position: refs/heads/master@{#364488}

Powered by Google App Engine
This is Rietveld 408576698