Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: content/renderer/media/webrtc_local_audio_track.h

Issue 1514143003: Add support for unmixed audio from remote WebRTC remote tracks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_local_audio_track.h
diff --git a/content/renderer/media/webrtc_local_audio_track.h b/content/renderer/media/webrtc_local_audio_track.h
index dab159f9357d09df457d036fc2d95be667b2ce1e..bf02f4b5c114a02b4b3f37872930bb73b9ddc38b 100644
--- a/content/renderer/media/webrtc_local_audio_track.h
+++ b/content/renderer/media/webrtc_local_audio_track.h
@@ -37,7 +37,7 @@ class WebRtcLocalAudioTrackAdapter;
// WebRtcAudioCapturer to get the captured data, and forward the data to
// its |sinks_|. The data flow can be stopped by disabling the audio track.
class CONTENT_EXPORT WebRtcLocalAudioTrack
perkj_chrome 2015/12/11 12:31:38 todo rename to match your MediaStreamRemoteAudioTr
tommi (sloooow) - chröme 2015/12/11 15:36:51 Done. (added TODO since the full separation is a l
- : NON_EXPORTED_BASE(public MediaStreamTrack) {
+ : NON_EXPORTED_BASE(public MediaStreamAudioTrack) {
public:
WebRtcLocalAudioTrack(WebRtcLocalAudioTrackAdapter* adapter,
const scoped_refptr<WebRtcAudioCapturer>& capturer,
@@ -48,11 +48,11 @@ class CONTENT_EXPORT WebRtcLocalAudioTrack
// Add a sink to the track. This function will trigger a OnSetFormat()
// call on the |sink|.
// Called on the main render thread.
- void AddSink(MediaStreamAudioSink* sink);
+ void AddSink(MediaStreamAudioSink* sink) override;
// Remove a sink from the track.
// Called on the main render thread.
- void RemoveSink(MediaStreamAudioSink* sink);
+ void RemoveSink(MediaStreamAudioSink* sink) override;
// Starts the local audio track. Called on the main render thread and
// should be called only once when audio track is created.
@@ -71,7 +71,7 @@ class CONTENT_EXPORT WebRtcLocalAudioTrack
// Returns the output format of the capture source. May return an invalid
// AudioParameters if the format is not yet available.
// Called on the main render thread.
- media::AudioParameters GetOutputFormat() const;
+ media::AudioParameters GetOutputFormat() const override;
// Method called by the capturer to deliver the capture data.
// Called on the capture audio thread.

Powered by Google App Engine
This is Rietveld 408576698