Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: content/renderer/media/media_stream_center.cc

Issue 1514143003: Add support for unmixed audio from remote WebRTC remote tracks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_center.cc
diff --git a/content/renderer/media/media_stream_center.cc b/content/renderer/media/media_stream_center.cc
index 53330cf3f9297efce4085d11b6f654931aa7ad20..9da9711488470f97714f81df48f7a2a6a0a60871 100644
--- a/content/renderer/media/media_stream_center.cc
+++ b/content/renderer/media/media_stream_center.cc
@@ -126,18 +126,15 @@ MediaStreamCenter::createWebAudioSourceFromMediaStreamTrack(
DVLOG(1) << "MediaStreamCenter::createWebAudioSourceFromMediaStreamTrack";
MediaStreamTrack* media_stream_track =
static_cast<MediaStreamTrack*>(track.extraData());
- // Only local audio track is supported now.
- // TODO(xians): Support remote audio track.
- if (!media_stream_track || !media_stream_track->is_local_track()) {
- NOTIMPLEMENTED();
- return NULL;
- }
+ if (!media_stream_track)
+ return nullptr;
perkj_chrome 2015/12/11 12:31:38 Do we want to log this ?
tommi (sloooow) - chröme 2015/12/11 15:36:51 Added a DLOG(ERROR)
blink::WebMediaStreamSource source = track.source();
DCHECK_EQ(source.type(), blink::WebMediaStreamSource::TypeAudio);
- WebRtcLocalAudioSourceProvider* source_provider =
- new WebRtcLocalAudioSourceProvider(track);
- return source_provider;
+
+ // TODO(tommi): Rename WebRtcLocalAudioSourceProvider to
+ // WebRtcAudioSourceProvider since it's not specific to local.
+ return new WebRtcLocalAudioSourceProvider(track);
}
void MediaStreamCenter::didStopLocalMediaStream(

Powered by Google App Engine
This is Rietveld 408576698