chrome/browser/ui/tab_helpers.cc - Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix up unittests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_generation_manager.cc ('K') | « chrome/browser/ui/login/login_prompt.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 261e792e2a4ff74fc24233ac17bf9470cabd2c43..a5646cedf3653afe445eebf4cfaf86f40438b322 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -136,12 +136,11 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

InfoBarService::CreateForWebContents(web_contents);

NavigationMetricsRecorder::CreateForWebContents(web_contents);

PasswordManagerDelegateImpl::CreateForWebContents(web_contents);

- PasswordManager::CreateForWebContentsAndDelegate(

- web_contents, PasswordManagerDelegateImpl::FromWebContents(web_contents));

PopupBlockerTabHelper::CreateForWebContents(web_contents);

PrefsTabHelper::CreateForWebContents(web_contents);

prerender::PrerenderTabHelper::CreateForWebContentsWithPasswordManager(

- web_contents, PasswordManager::FromWebContents(web_contents));

+ web_contents,

+ PasswordManagerDelegateImpl::GetManagerFromWebContents(web_contents));

SSLTabHelper::CreateForWebContents(web_contents);

TabSpecificContentSettings::CreateForWebContents(web_contents);

TranslateTabHelper::CreateForWebContents(web_contents);

@@ -160,7 +159,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

HungPluginTabHelper::CreateForWebContents(web_contents);

ManagePasswordsBubbleUIController::CreateForWebContents(web_contents);

NavigationTimeHelper::CreateForWebContents(web_contents);

- PasswordGenerationManager::CreateForWebContents(web_contents);

PDFTabHelper::CreateForWebContents(web_contents);

PermissionBubbleManager::CreateForWebContents(web_contents);

PluginObserver::CreateForWebContents(web_contents);

@@ -210,7 +208,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

std::string(),

NULL)) {

OneClickSigninHelper::CreateForWebContentsWithPasswordManager(

- web_contents, PasswordManager::FromWebContents(web_contents));

+ web_contents,

+ PasswordManagerDelegateImpl::GetManagerFromWebContents(web_contents));

}

#endif

}