chrome/browser/ui/gtk/password_generation_bubble_gtk.cc - Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix up unittests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_generation_manager.cc ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/login/login_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc b/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

index 8fa8b857e0a203bb35f09fefb114b912e395a16e..c1bdd66a51abd6f18012ed5443446f349fcb3215 100644

--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

@@ -6,6 +6,7 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/password_manager/password_manager.h"

+#include "chrome/browser/password_manager/password_manager_delegate_impl.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -130,8 +131,8 @@ void PasswordGenerationBubbleGtk::OnAcceptClicked(GtkWidget* widget) {

render_view_host->Send(new AutofillMsg_GeneratedPasswordAccepted(

render_view_host->GetRoutingID(),

base::UTF8ToUTF16(gtk_entry_get_text(GTK_ENTRY(text_field_)))));

- PasswordManager::FromWebContents(web_contents_)->

- SetFormHasGeneratedPassword(form_);

+ PasswordManagerDelegateImpl::GetManagerFromWebContents(web_contents_)

+ ->SetFormHasGeneratedPassword(form_);

bubble_->Close();

}