chrome/browser/ui/login/login_prompt.cc - Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Handle WebContents having no PasswordManagerDelegateImpl attached Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/login/login_prompt.cc

diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc

index cc77c5946bd42ff53a99788d2e2eec5f01b7b985..bdfb8c3bf8094c0a2ca1e21ee581c2bfe5b68c4b 100644

--- a/chrome/browser/ui/login/login_prompt.cc

+++ b/chrome/browser/ui/login/login_prompt.cc

@@ -12,6 +12,7 @@

#include "base/synchronization/lock.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/password_manager/password_manager.h"

+#include "chrome/browser/password_manager/password_manager_delegate_impl.h"

#include "chrome/browser/prerender/prerender_contents.h"

#include "chrome/browser/tab_contents/tab_util.h"

#include "content/public/browser/browser_thread.h"

@@ -434,7 +435,7 @@ void LoginDialogCallback(const GURL& request_url,

}

PasswordManager* password_manager =

- PasswordManager::FromWebContents(parent_contents);

+ PasswordManagerDelegateImpl::GetManagerFromWebContents(parent_contents);

if (!password_manager) {

// Same logic as above.

handler->CancelAuth();

« no previous file with comments | « chrome/browser/ui/gtk/password_generation_bubble_gtk.cc ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »