chrome/browser/password_manager/password_generation_interactive_uitest.cc - Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_generation_interactive_uitest.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Handle WebContents having no PasswordManagerDelegateImpl attached Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_form_manager_unittest.cc ('k') | chrome/browser/password_manager/password_generation_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_generation_interactive_uitest.cc

diff --git a/chrome/browser/password_manager/password_generation_interactive_uitest.cc b/chrome/browser/password_manager/password_generation_interactive_uitest.cc

index fff3b0949441899f10e0e6295d288f39fa6966aa..ca2b07cdb697249a3c0703cafde04d381a32ce03 100644

--- a/chrome/browser/password_manager/password_generation_interactive_uitest.cc

+++ b/chrome/browser/password_manager/password_generation_interactive_uitest.cc

@@ -4,6 +4,7 @@

#include "base/command_line.h"

#include "chrome/browser/password_manager/password_generation_manager.h"

+#include "chrome/browser/password_manager/password_manager_delegate_impl.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/autofill/password_generation_popup_observer.h"

#include "chrome/browser/ui/browser.h"

@@ -61,7 +62,8 @@ class PasswordGenerationInteractiveTest : public InProcessBrowserTest {

// Set observer for popup.

PasswordGenerationManager* generation_manager =

- PasswordGenerationManager::FromWebContents(GetWebContents());

+ PasswordManagerDelegateImpl::GetGenerationManagerFromWebContents(

+ GetWebContents());

generation_manager->SetTestObserver(&observer_);

ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

@@ -72,7 +74,8 @@ class PasswordGenerationInteractiveTest : public InProcessBrowserTest {

virtual void CleanUpOnMainThread() OVERRIDE {

// Cleanup UI.

PasswordGenerationManager* generation_manager =

- PasswordGenerationManager::FromWebContents(GetWebContents());

+ PasswordManagerDelegateImpl::GetGenerationManagerFromWebContents(

+ GetWebContents());

generation_manager->HidePopup();

}