Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: chrome/browser/password_manager/content_password_manager_driver.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle WebContents having no PasswordManagerDelegateImpl attached Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/content_password_manager_driver.cc
diff --git a/chrome/browser/password_manager/content_password_manager_driver.cc b/chrome/browser/password_manager/content_password_manager_driver.cc
index f8716c56dc6434debff7120576dc836b67912c7d..4fbf61e6c5d57e0b4f17fbf71f913df283634dde 100644
--- a/chrome/browser/password_manager/content_password_manager_driver.cc
+++ b/chrome/browser/password_manager/content_password_manager_driver.cc
@@ -15,19 +15,18 @@
#include "net/cert/cert_status_flags.h"
ContentPasswordManagerDriver::ContentPasswordManagerDriver(
- content::WebContents* web_contents)
- : web_contents_(web_contents) {
-}
+ content::WebContents* web_contents,
+ PasswordManagerDelegate* delegate)
+ : web_contents_(web_contents),
+ password_manager_(web_contents, delegate),
+ password_generation_manager_(web_contents, delegate) {}
-ContentPasswordManagerDriver::~ContentPasswordManagerDriver() {
-}
+ContentPasswordManagerDriver::~ContentPasswordManagerDriver() {}
void ContentPasswordManagerDriver::FillPasswordForm(
const autofill::PasswordFormFillData& form_data) {
- web_contents_->GetRenderViewHost()->Send(
- new AutofillMsg_FillPasswordForm(
- web_contents_->GetRenderViewHost()->GetRoutingID(),
- form_data));
+ web_contents_->GetRenderViewHost()->Send(new AutofillMsg_FillPasswordForm(
+ web_contents_->GetRenderViewHost()->GetRoutingID(), form_data));
}
bool ContentPasswordManagerDriver::DidLastPageLoadEncounterSSLErrors() {
@@ -40,3 +39,12 @@ bool ContentPasswordManagerDriver::DidLastPageLoadEncounterSSLErrors() {
return net::IsCertStatusError(entry->GetSSL().cert_status);
}
+
+PasswordGenerationManager*
+ContentPasswordManagerDriver::GetPasswordGenerationManager() {
+ return &password_generation_manager_;
+}
+
+PasswordManager* ContentPasswordManagerDriver::GetPasswordManager() {
+ return &password_manager_;
+}

Powered by Google App Engine
This is Rietveld 408576698