chrome/browser/chromeos/login/webui_login_view.cc - Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/webui_login_view.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Handle WebContents having no PasswordManagerDelegateImpl attached Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/simple_web_view_dialog.cc ('k') | chrome/browser/password_manager/content_password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/webui_login_view.cc

diff --git a/chrome/browser/chromeos/login/webui_login_view.cc b/chrome/browser/chromeos/login/webui_login_view.cc

index 4e5ee81b9832372cfa8975abd887ece943b7b2c1..cd3e83e0141fd0dcc38e6d71594663de91137327 100644

--- a/chrome/browser/chromeos/login/webui_login_view.cc

+++ b/chrome/browser/chromeos/login/webui_login_view.cc

@@ -168,8 +168,6 @@ void WebUILoginView::Init() {

// Create the password manager that is needed for the proxy.

PasswordManagerDelegateImpl::CreateForWebContents(web_contents);

- PasswordManager::CreateForWebContentsAndDelegate(

- web_contents, PasswordManagerDelegateImpl::FromWebContents(web_contents));

// LoginHandlerViews uses a constrained window for the password manager view.

WebContentsModalDialogManager::CreateForWebContents(web_contents);