Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/ui/tab_helpers.cc

Issue 151413008: Move ownership of Password(Generation)Manager to ContentPasswordDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle WebContents having no PasswordManagerDelegateImpl attached Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/login/login_prompt.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_helpers.h" 5 #include "chrome/browser/ui/tab_helpers.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 9 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
10 #include "chrome/browser/extensions/tab_helper.h" 10 #include "chrome/browser/extensions/tab_helper.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 BookmarkTabHelper::CreateForWebContents(web_contents); 129 BookmarkTabHelper::CreateForWebContents(web_contents);
130 chrome_browser_net::NetErrorTabHelper::CreateForWebContents(web_contents); 130 chrome_browser_net::NetErrorTabHelper::CreateForWebContents(web_contents);
131 CoreTabHelper::CreateForWebContents(web_contents); 131 CoreTabHelper::CreateForWebContents(web_contents);
132 extensions::TabHelper::CreateForWebContents(web_contents); 132 extensions::TabHelper::CreateForWebContents(web_contents);
133 FaviconTabHelper::CreateForWebContents(web_contents); 133 FaviconTabHelper::CreateForWebContents(web_contents);
134 FindTabHelper::CreateForWebContents(web_contents); 134 FindTabHelper::CreateForWebContents(web_contents);
135 HistoryTabHelper::CreateForWebContents(web_contents); 135 HistoryTabHelper::CreateForWebContents(web_contents);
136 InfoBarService::CreateForWebContents(web_contents); 136 InfoBarService::CreateForWebContents(web_contents);
137 NavigationMetricsRecorder::CreateForWebContents(web_contents); 137 NavigationMetricsRecorder::CreateForWebContents(web_contents);
138 PasswordManagerDelegateImpl::CreateForWebContents(web_contents); 138 PasswordManagerDelegateImpl::CreateForWebContents(web_contents);
139 PasswordManager::CreateForWebContentsAndDelegate(
140 web_contents, PasswordManagerDelegateImpl::FromWebContents(web_contents));
141 PopupBlockerTabHelper::CreateForWebContents(web_contents); 139 PopupBlockerTabHelper::CreateForWebContents(web_contents);
142 PrefsTabHelper::CreateForWebContents(web_contents); 140 PrefsTabHelper::CreateForWebContents(web_contents);
143 prerender::PrerenderTabHelper::CreateForWebContentsWithPasswordManager( 141 prerender::PrerenderTabHelper::CreateForWebContentsWithPasswordManager(
144 web_contents, PasswordManager::FromWebContents(web_contents)); 142 web_contents,
143 PasswordManagerDelegateImpl::GetManagerFromWebContents(web_contents));
145 SSLTabHelper::CreateForWebContents(web_contents); 144 SSLTabHelper::CreateForWebContents(web_contents);
146 TabSpecificContentSettings::CreateForWebContents(web_contents); 145 TabSpecificContentSettings::CreateForWebContents(web_contents);
147 TranslateTabHelper::CreateForWebContents(web_contents); 146 TranslateTabHelper::CreateForWebContents(web_contents);
148 147
149 // --- Platform-specific tab helpers --- 148 // --- Platform-specific tab helpers ---
150 149
151 #if defined(OS_ANDROID) 150 #if defined(OS_ANDROID)
152 ContextMenuHelper::CreateForWebContents(web_contents); 151 ContextMenuHelper::CreateForWebContents(web_contents);
153 SingleTabModeTabHelper::CreateForWebContents(web_contents); 152 SingleTabModeTabHelper::CreateForWebContents(web_contents);
154 WindowAndroidHelper::CreateForWebContents(web_contents); 153 WindowAndroidHelper::CreateForWebContents(web_contents);
155 #else 154 #else
156 chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents); 155 chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents);
157 extensions::ExtensionWebContentsObserver::CreateForWebContents(web_contents); 156 extensions::ExtensionWebContentsObserver::CreateForWebContents(web_contents);
158 extensions::WebNavigationTabObserver::CreateForWebContents(web_contents); 157 extensions::WebNavigationTabObserver::CreateForWebContents(web_contents);
159 ExternalProtocolObserver::CreateForWebContents(web_contents); 158 ExternalProtocolObserver::CreateForWebContents(web_contents);
160 HungPluginTabHelper::CreateForWebContents(web_contents); 159 HungPluginTabHelper::CreateForWebContents(web_contents);
161 ManagePasswordsBubbleUIController::CreateForWebContents(web_contents); 160 ManagePasswordsBubbleUIController::CreateForWebContents(web_contents);
162 NavigationTimeHelper::CreateForWebContents(web_contents); 161 NavigationTimeHelper::CreateForWebContents(web_contents);
163 PasswordGenerationManager::CreateForWebContents(web_contents);
164 PDFTabHelper::CreateForWebContents(web_contents); 162 PDFTabHelper::CreateForWebContents(web_contents);
165 PermissionBubbleManager::CreateForWebContents(web_contents); 163 PermissionBubbleManager::CreateForWebContents(web_contents);
166 PluginObserver::CreateForWebContents(web_contents); 164 PluginObserver::CreateForWebContents(web_contents);
167 SadTabHelper::CreateForWebContents(web_contents); 165 SadTabHelper::CreateForWebContents(web_contents);
168 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents); 166 safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);
169 SearchEngineTabHelper::CreateForWebContents(web_contents); 167 SearchEngineTabHelper::CreateForWebContents(web_contents);
170 SearchTabHelper::CreateForWebContents(web_contents); 168 SearchTabHelper::CreateForWebContents(web_contents);
171 TabContentsSyncedTabDelegate::CreateForWebContents(web_contents); 169 TabContentsSyncedTabDelegate::CreateForWebContents(web_contents);
172 ThumbnailTabHelper::CreateForWebContents(web_contents); 170 ThumbnailTabHelper::CreateForWebContents(web_contents);
173 web_modal::WebContentsModalDialogManager::CreateForWebContents(web_contents); 171 web_modal::WebContentsModalDialogManager::CreateForWebContents(web_contents);
(...skipping 29 matching lines...) Expand all
203 // If this is not an incognito window, setup to handle one-click login. 201 // If this is not an incognito window, setup to handle one-click login.
204 // We don't want to check that the profile is already connected at this time 202 // We don't want to check that the profile is already connected at this time
205 // because the connected state may change while this tab is open. Having a 203 // because the connected state may change while this tab is open. Having a
206 // one-click signin helper attached does not cause problems if the profile 204 // one-click signin helper attached does not cause problems if the profile
207 // happens to be already connected. 205 // happens to be already connected.
208 if (OneClickSigninHelper::CanOffer(web_contents, 206 if (OneClickSigninHelper::CanOffer(web_contents,
209 OneClickSigninHelper::CAN_OFFER_FOR_ALL, 207 OneClickSigninHelper::CAN_OFFER_FOR_ALL,
210 std::string(), 208 std::string(),
211 NULL)) { 209 NULL)) {
212 OneClickSigninHelper::CreateForWebContentsWithPasswordManager( 210 OneClickSigninHelper::CreateForWebContentsWithPasswordManager(
213 web_contents, PasswordManager::FromWebContents(web_contents)); 211 web_contents,
212 PasswordManagerDelegateImpl::GetManagerFromWebContents(web_contents));
214 } 213 }
215 #endif 214 #endif
216 } 215 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/login/login_prompt.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698