Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 151413006: Revert of Add missing test targets to chrome_official_builder for Windows. (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Add missing test targets to chrome_official_builder for Windows. (https://codereview.chromium.org/138333005/) Reason for revert: These were removed because the toolchain can no longer link them. Original issue's description: > Add missing test targets to chrome_official_builder for Windows. > > BUG=334006 > R=cpu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245379 TBR=cpu@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=334006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M build/all.gyp View 1 chunk +6 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
Created Revert of Add missing test targets to chrome_official_builder for Windows.
6 years, 10 months ago (2014-01-31 16:39:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/151413006/1
6 years, 10 months ago (2014-01-31 16:51:40 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 16:51:43 UTC) #3
commit-bot: I haz the power
Failed to apply patch for build/all.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-31 16:51:44 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 16:51:44 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 16:51:54 UTC) #6
Paweł Hajdan Jr.
LGTM
6 years, 8 months ago (2014-04-01 14:16:45 UTC) #7
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 8 months ago (2014-04-07 23:11:54 UTC) #8
jschuh
6 years, 8 months ago (2014-04-07 23:12:03 UTC) #9
The CQ bit was unchecked by jschuh@chromium.org

Powered by Google App Engine
This is Rietveld 408576698