Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151413002: Files.app: Clean DirectoryModel. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Clean DirectoryModel. This CL do random cleanup involved with DirectoryModel. * Remove unused parameters and variables. * Remove methods that just delegates to another method or are called from one place, in order to reduce the number of jump when reading codes. * Merge the specialSearch method into changeDirectoryEntry by extracting the difference of the two mehtods to createDirectoryContents_. BUG=none TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248919

Patch Set 1 : #

Total comments: 10

Patch Set 2 : Fixed #

Patch Set 3 : Fixed a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -173 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/directory_contents.js View 1 10 chunks +9 lines, -28 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/directory_model.js View 1 2 7 chunks +92 lines, -144 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (0 generated)
hirono
6 years, 10 months ago (2014-01-31 13:01:14 UTC) #1
hirono
PTAL the CL? Thanks!
6 years, 10 months ago (2014-01-31 13:10:22 UTC) #2
mtomasz
Nice cleanup. https://codereview.chromium.org/151413002/diff/50001/chrome/browser/resources/file_manager/foreground/js/directory_contents.js File chrome/browser/resources/file_manager/foreground/js/directory_contents.js (left): https://codereview.chromium.org/151413002/diff/50001/chrome/browser/resources/file_manager/foreground/js/directory_contents.js#oldcode523 chrome/browser/resources/file_manager/foreground/js/directory_contents.js:523: this.scanner_ = this.scannerFactory_(); I'm getting a JS ...
6 years, 10 months ago (2014-02-04 02:20:12 UTC) #3
hirono
Thanks! https://codereview.chromium.org/151413002/diff/50001/chrome/browser/resources/file_manager/foreground/js/directory_contents.js File chrome/browser/resources/file_manager/foreground/js/directory_contents.js (left): https://codereview.chromium.org/151413002/diff/50001/chrome/browser/resources/file_manager/foreground/js/directory_contents.js#oldcode523 chrome/browser/resources/file_manager/foreground/js/directory_contents.js:523: this.scanner_ = this.scannerFactory_(); On 2014/02/04 02:20:12, mtomasz wrote: ...
6 years, 10 months ago (2014-02-04 05:53:11 UTC) #4
mtomasz
lgtm!
6 years, 10 months ago (2014-02-04 05:56:00 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 05:59:20 UTC) #6
hirono
On 2014/02/04 05:56:00, mtomasz wrote: > lgtm! Thanks!
6 years, 10 months ago (2014-02-04 05:59:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-04 05:59:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:35:33 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222851
6 years, 10 months ago (2014-02-04 06:35:34 UTC) #10
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 08:24:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-04 08:24:18 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 09:23:41 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120612
6 years, 10 months ago (2014-02-04 09:23:41 UTC) #14
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 09:30:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-04 09:31:55 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 10:30:58 UTC) #17
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120658
6 years, 10 months ago (2014-02-04 10:30:58 UTC) #18
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 10:32:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-04 10:32:43 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 11:31:51 UTC) #21
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120690
6 years, 10 months ago (2014-02-04 11:31:52 UTC) #22
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 11:37:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-04 11:37:29 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 12:52:59 UTC) #25
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120724
6 years, 10 months ago (2014-02-04 12:53:00 UTC) #26
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 15:03:03 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-04 15:03:29 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:09:03 UTC) #29
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120853
6 years, 10 months ago (2014-02-04 16:09:03 UTC) #30
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:09:05 UTC) #31
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-05 02:39:00 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/130001
6 years, 10 months ago (2014-02-05 03:43:23 UTC) #33
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-05 05:20:02 UTC) #34
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
6 years, 10 months ago (2014-02-05 06:26:25 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/151413002/1110001
6 years, 10 months ago (2014-02-05 06:28:34 UTC) #36
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:25:54 UTC) #37
Message was sent while issue was closed. 
Change committed as 248919

Powered by Google App Engine
This is Rietveld 408576698