Fix clone() behavior on CanvasCaptureMediaStreamTrack

Fix clone() behavior on CanvasCaptureMediaStreamTrack

This CL handles clone() behavior on CanvasCaptureMediaStreamTrack
such that it overrides MediaStreamTrack. Clone object holds onto
the original <canvas> and CanvasCaptureHandler as well.

BUG=524218
TEST= Ran this demo that clones&plays&stops a track with MediaCaptureFromElement flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture7.html

Committed: https://crrev.com/49eb643afcbe40a28ddb1a5948387c1b2a16dc80
Cr-Commit-Position: refs/heads/master@{#364922}

[emircan, 2015-12-11 01:47:41]

Description was changed from

==========
clone track

BUG=524218
==========

to

==========
Add appropriate clone behavior on CanvasCaptureMediaStreamTrack

BUG=524218
==========

[emircan, 2015-12-11 01:47:41]

emircan@chromium.org changed reviewers:
+ perkj@chromium.org

[emircan, 2015-12-11 01:56:56]

Description was changed from

==========
Add appropriate clone behavior on CanvasCaptureMediaStreamTrack

BUG=524218
==========

to

==========
Fix clone() behavior on CanvasCaptureMediaStreamTrack

This CL handles clone() behavior on CanvasCaptureMediaStreamTrack
such that it overrides MediaStreamTrack. Clone object holds onto
the original <canvas> and CanvasCaptureHandler as well.

BUG=524218
TEST= Ran this demo that clones&plays&stops a track with MediaCaptureFromElement
flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture7.html
==========

[emircan, 2015-12-11 01:57:51]

PTAL.

[perkj_chrome, 2015-12-11 16:05:19]

lgtm if the layout test is addressed.

However, I am no owner.

https://codereview.chromium.org/1514113005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
(right):

https://codereview.chromium.org/1514113005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html:28:
var canvas = cloned_track.requestFrame();
canvas? 
Named something else? Should also check that this is valid data?

[emircan, 2015-12-11 18:30:06]

Thanks.

https://codereview.chromium.org/1514113005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
(right):

https://codereview.chromium.org/1514113005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html:28:
var canvas = cloned_track.requestFrame();
On 2015/12/11 16:05:19, perkj wrote:
> canvas? 
> Named something else? Should also check that this is valid data? 

Actually it is void. I am removing the return value.

[emircan, 2015-12-11 18:31:32]

emircan@chromium.org changed reviewers:
+ haraken@chromium.org

[emircan, 2015-12-11 18:31:33]

haraken@chromium.org, I need the owners review. PTAL?

[haraken, 2015-12-12 07:37:34]

LGTM

[haraken, 2015-12-12 07:37:46]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-12-12 07:37:46]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@chromium.org
Link to the patchset: https://codereview.chromium.org/1514113005/#ps20001
(title: "perkj@ comments.")

[commit-bot: I haz the power, 2015-12-12 07:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514113005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514113005/20001

[commit-bot: I haz the power, 2015-12-12 07:47:09]

Description was changed from

==========
Fix clone() behavior on CanvasCaptureMediaStreamTrack

This CL handles clone() behavior on CanvasCaptureMediaStreamTrack
such that it overrides MediaStreamTrack. Clone object holds onto
the original <canvas> and CanvasCaptureHandler as well.

BUG=524218
TEST= Ran this demo that clones&plays&stops a track with MediaCaptureFromElement
flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture7.html
==========

to

==========
Fix clone() behavior on CanvasCaptureMediaStreamTrack

This CL handles clone() behavior on CanvasCaptureMediaStreamTrack
such that it overrides MediaStreamTrack. Clone object holds onto
the original <canvas> and CanvasCaptureHandler as well.

BUG=524218
TEST= Ran this demo that clones&plays&stops a track with MediaCaptureFromElement
flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture7.html
==========

[commit-bot: I haz the power, 2015-12-12 07:47:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-12 07:48:05]

Description was changed from

==========
Fix clone() behavior on CanvasCaptureMediaStreamTrack

This CL handles clone() behavior on CanvasCaptureMediaStreamTrack
such that it overrides MediaStreamTrack. Clone object holds onto
the original <canvas> and CanvasCaptureHandler as well.

BUG=524218
TEST= Ran this demo that clones&plays&stops a track with MediaCaptureFromElement
flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture7.html
==========

to

==========
Fix clone() behavior on CanvasCaptureMediaStreamTrack

This CL handles clone() behavior on CanvasCaptureMediaStreamTrack
such that it overrides MediaStreamTrack. Clone object holds onto
the original <canvas> and CanvasCaptureHandler as well.

BUG=524218
TEST= Ran this demo that clones&plays&stops a track with MediaCaptureFromElement
flag enabled.
https://rawgit.com/uysalere/js-demos/master/canvascapture7.html

Committed: https://crrev.com/49eb643afcbe40a28ddb1a5948387c1b2a16dc80
Cr-Commit-Position: refs/heads/master@{#364922}
==========

[commit-bot: I haz the power, 2015-12-12 07:48:06]

Patchset 2 (id:??) landed as
https://crrev.com/49eb643afcbe40a28ddb1a5948387c1b2a16dc80
Cr-Commit-Position: refs/heads/master@{#364922}