Fix intermittent GrAutoLocaleSetter crashes on Windows

Try to fix intermittent GrAutoLocaleSetter crashes on Windows

Try to fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().

Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.

Committed: https://skia.googlesource.com/skia/+/aab16e54cb6ab712b477ed9eed8b9aa52098572c

[Kimmo Kinnunen, 2015-12-10 13:20:56]

Description was changed from

==========
Fix intermittent GrAutoLocaleSetter crashes on Windows

Fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().
==========

to

==========
Fix intermittent GrAutoLocaleSetter crashes on Windows

Fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().

Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.
==========

[Kimmo Kinnunen, 2015-12-10 13:20:56]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[Kimmo Kinnunen, 2015-12-10 13:21:44]

I could not repro the crash, though.

http://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleB-GPU-...

[Kimmo Kinnunen, 2015-12-10 13:25:16]

Description was changed from

==========
Fix intermittent GrAutoLocaleSetter crashes on Windows

Fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().

Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.
==========

to

==========
Try to fix intermittent GrAutoLocaleSetter crashes on Windows

Try to fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().

Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.
==========

[Kimmo Kinnunen, 2015-12-10 13:26:05]

https://msdn.microsoft.com/en-us/library/x99tb11d.aspx

[bsalomon, 2015-12-10 15:12:24]

https://codereview.chromium.org/1514083002/diff/20001/src/gpu/GrAutoLocaleSet...
File src/gpu/GrAutoLocaleSetter.h (right):

https://codereview.chromium.org/1514083002/diff/20001/src/gpu/GrAutoLocaleSet...
src/gpu/GrAutoLocaleSetter.h:49: if (!fOldLocale.isEmpty()) {
IIUC empty string is valid.
"If locale points to an empty string, the locale is the implementation-defined
native environment."

Maybe that never gets returned by  setlocale, though?

[Kimmo Kinnunen, 2015-12-11 07:50:17]

https://codereview.chromium.org/1514083002/diff/20001/src/gpu/GrAutoLocaleSet...
File src/gpu/GrAutoLocaleSetter.h (right):

https://codereview.chromium.org/1514083002/diff/20001/src/gpu/GrAutoLocaleSet...
src/gpu/GrAutoLocaleSetter.h:49: if (!fOldLocale.isEmpty()) {
On 2015/12/10 15:12:23, bsalomon wrote:
> IIUC empty string is valid.
> "If locale points to an empty string, the locale is the implementation-defined
> native environment."
> 
> Maybe that never gets returned by  setlocale, though?

Done.

[bsalomon, 2015-12-11 13:59:32]

lgtm

[Kimmo Kinnunen, 2015-12-14 06:58:37]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-12-14 06:58:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514083002/40001

[commit-bot: I haz the power, 2015-12-14 07:12:34]

Description was changed from

==========
Try to fix intermittent GrAutoLocaleSetter crashes on Windows

Try to fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().

Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.
==========

to

==========
Try to fix intermittent GrAutoLocaleSetter crashes on Windows

Try to fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().

Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.

Committed:
https://skia.googlesource.com/skia/+/aab16e54cb6ab712b477ed9eed8b9aa52098572c
==========

[commit-bot: I haz the power, 2015-12-14 07:12:35]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/aab16e54cb6ab712b477ed9eed8b9aa52098572c