Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1514033002: Initialize glGen* call id args to zero (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@run-debug-context
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initialize glGen* call id args to zero Initialize glGenTexture, glGenBuffer call id buffer items to zero before calls. Otherwise it's not easy to check if the call succeeded or not. Assert the rule in debug gl context. Make TesselatingPathRendererTests use debug gl context. It exercises some of the GenBuffers call sites. Committed: https://skia.googlesource.com/skia/+/546eb5c57aebee47172f9d2a3eae6b49945dba08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M src/gpu/gl/GrGLGpu.cpp View 9 chunks +9 lines, -4 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
Kimmo Kinnunen
5 years ago (2015-12-10 09:11:37 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-10 15:13:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514033002/1
5 years ago (2015-12-11 07:51:46 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-11 08:05:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/546eb5c57aebee47172f9d2a3eae6b49945dba08

Powered by Google App Engine
This is Rietveld 408576698