Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 151403003: Simpler repro for bug 2989. (Closed)

Created:
6 years, 10 months ago by Jarin
Modified:
6 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Simpler repro for bug 2989. We do not correctly handle accesses to f.arguments after one of the argument has changed (where f is crankshafted). R=machenbach@chromium.org BUG=v8:2989 LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-2989.js View 1 chunk +11 lines, -9 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 10 months ago (2014-01-31 14:02:08 UTC) #1
Michael Achenbach
LGTM
6 years, 10 months ago (2014-01-31 14:06:26 UTC) #2
Jarin
6 years, 10 months ago (2014-01-31 16:13:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698