Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1513993004: Fix stack overflow check in InvokeClosure. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix stack overflow check in InvokeClosure. Isolate::saved_stack_limit() answers the limit of the Dart stack, which is different from the C stack when using the simulators. Since we are recursing in C, we want to check against the C stack's limit. This overflow check is only needed to support --no-lazy-dispatchers, which is part of precompilation. BUG=http://dartbug.com/24659 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/5111482ab9bfac1f3e27124efb182ae7068a1b94

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M runtime/vm/dart_entry.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
5 years ago (2015-12-10 18:30:16 UTC) #2
regis
LGTM
5 years ago (2015-12-10 19:25:17 UTC) #3
rmacnak
5 years ago (2015-12-10 22:06:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5111482ab9bfac1f3e27124efb182ae7068a1b94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698