Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1513933005: Reland: Make the check for compat mode explicit. (Closed)

Created:
5 years ago by David Tseng
Modified:
5 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Make the check for compat mode explicit. This cl now makes a few more refinments: - explicitly sets the current range when significant tab events happen, but only if the tab (rootWebArea node) itself has focus. - checks to see that the aura view has focus before entering compat mode. TEST= 1. move to status tray (verify compat), press escape (verify classic) and that classic gets all key commands 2. open two tabs; switch between the two tabs and verify that classic commands still work. 3. switch to launcher (alt+shift+l); verify that compat commands work. Important because launcher sets only focused state (but not focusable state). 4. open a new window with multiple tabs and do the above steps. 5. open a new tab and verify you can type in the address bar and receive feedback. Important because this is an instance where we stay in compat but also receive a chrome.tabs event. The rootWebArea in thi caase has no focused state set. Committed: https://crrev.com/6d2b2c67746c12eb5264a29e59a6dcafa6a96916 Cr-Commit-Position: refs/heads/master@{#364482}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
David Tseng
5 years ago (2015-12-10 19:06:05 UTC) #3
dmazzoni
lgtm
5 years ago (2015-12-10 20:12:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513933005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513933005/1
5 years ago (2015-12-10 20:52:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 21:22:39 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 21:23:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d2b2c67746c12eb5264a29e59a6dcafa6a96916
Cr-Commit-Position: refs/heads/master@{#364482}

Powered by Google App Engine
This is Rietveld 408576698