DescriptionReland: Make the check for compat mode explicit.
This cl now makes a few more refinments:
- explicitly sets the current range when significant tab events happen, but only if the tab (rootWebArea node) itself has focus.
- checks to see that the aura view has focus before entering compat mode.
TEST=
1. move to status tray (verify compat), press escape (verify classic) and that classic gets all key commands
2. open two tabs; switch between the two tabs and verify that classic commands still work.
3. switch to launcher (alt+shift+l); verify that compat commands work. Important because launcher sets only focused state (but not focusable state).
4. open a new window with multiple tabs and do the above steps.
5. open a new tab and verify you can type in the address bar and receive feedback. Important because this is an instance where we stay in compat but also receive a chrome.tabs event. The rootWebArea in thi caase has no focused state set.
Committed: https://crrev.com/6d2b2c67746c12eb5264a29e59a6dcafa6a96916
Cr-Commit-Position: refs/heads/master@{#364482}
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|