Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1513923003: Dart floating-point array encoders should accept a List<double> (Closed)

Created:
5 years ago by jsimmons1
Modified:
5 years ago
Reviewers:
zra, abarth-chromium, Hixie
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart floating-point array encoders should accept a List<double> BUG= R=abarth@chromium.org, zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e93037e1a5b2d84d2df3be87579f86f73d842449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M mojo/dart/packages/mojo/lib/src/codec.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
abarth-chromium
LGTM
5 years ago (2015-12-10 18:28:56 UTC) #3
zra
lgtm
5 years ago (2015-12-10 18:31:36 UTC) #4
zra
Thanks!
5 years ago (2015-12-10 18:32:09 UTC) #5
jsimmons1
5 years ago (2015-12-10 18:35:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e93037e1a5b2d84d2df3be87579f86f73d842449 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698