Polymorphic calls in precompilation invoke megamorphic calls when tests fail (instead of deoptimizi…

Polymorphic calls in precompilation invoke megamorphic calls when tests fail (instead of deoptimizing). Move the megamorphic call into a slow path stub. Cleanups.
Allow truning off speculative inlining if --max_speculative_inlining_attempts <=0

BUG=
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/3a46cc28b775c5a9df0ea40133f78e18e2f873be

[srdjan, 2015-12-09 23:46:40]

Description was changed from

==========
Polymorphic calls in precompilation invoke megamorphic calls when tests fail
(instead of deoptimizing). Move the megamorphic call into a slow path stub.
Cleanups

BUG=
==========

to

==========
Polymorphic calls in precompilation invoke megamorphic calls when tests fail
(instead of deoptimizing). Move the megamorphic call into a slow path stub.
Cleanups.
Allow truning off speculative inlining if --max_speculative_inlining_attempts
<=0

BUG=
==========

[srdjan, 2015-12-10 20:31:24]

srdjan@google.com changed reviewers:
+ fschneider@google.com, rmacnak@google.com

[Florian Schneider, 2015-12-14 16:07:03]

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_arm.cc:35: Assembler* assem =
compiler->assembler();
s/assem/assembler/

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_arm.cc:1292:
AddCurrentDescriptor(RawPcDescriptors::kOther, Thread::kNoDeoptId, token_pos);
Move this into the else-branches below, so that we don't record two descriptors
of the same type if Compiler::always_optimize() is true.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_arm64.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_arm64.cc:1282:
AddCurrentDescriptor(RawPcDescriptors::kOther,
Move this into the else-branches below, so that we don't record two descriptors
of the same type if Compiler::always_optimize() is true.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_ia32.cc:1316: if (Compiler::always_optimize()) {
This seems never true on ia32 and won't be tested. Maybe just
ASSERT(!Compiler::always_optimize())?

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_mips.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_mips.cc:1303:
AddCurrentDescriptor(RawPcDescriptors::kOther,
Move this into the else-branches below, so that we don't record two descriptors
of the same type if Compiler::always_optimize() is true.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_x64.cc:1313:
AddCurrentDescriptor(RawPcDescriptors::kOther,
Move this into the else-branches below, so that we don't record two descriptors
of the same type if Compiler::always_optimize() is true.

[srdjan, 2015-12-15 17:52:03]

PTAL

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_arm.cc:35: Assembler* assem =
compiler->assembler();
On 2015/12/14 16:07:03, Florian Schneider wrote:
> s/assem/assembler/

Done here and below (old code).

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_arm.cc:1292:
AddCurrentDescriptor(RawPcDescriptors::kOther, Thread::kNoDeoptId, token_pos);
On 2015/12/14 16:07:03, Florian Schneider wrote:
> Move this into the else-branches below, so that we don't record two
descriptors
> of the same type if Compiler::always_optimize() is true.

Done.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_arm64.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_arm64.cc:1282:
AddCurrentDescriptor(RawPcDescriptors::kOther,
On 2015/12/14 16:07:03, Florian Schneider wrote:
> Move this into the else-branches below, so that we don't record two
descriptors
> of the same type if Compiler::always_optimize() is true.

Done.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_ia32.cc:1316: if (Compiler::always_optimize()) {
On 2015/12/14 16:07:03, Florian Schneider wrote:
> This seems never true on ia32 and won't be tested. Maybe just
> ASSERT(!Compiler::always_optimize())?

Done.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_mips.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_mips.cc:1303:
AddCurrentDescriptor(RawPcDescriptors::kOther,
On 2015/12/14 16:07:03, Florian Schneider wrote:
> Move this into the else-branches below, so that we don't record two
descriptors
> of the same type if Compiler::always_optimize() is true.

Done.

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://codereview.chromium.org/1513883002/diff/90001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler_x64.cc:1313:
AddCurrentDescriptor(RawPcDescriptors::kOther,
On 2015/12/14 16:07:03, Florian Schneider wrote:
> Move this into the else-branches below, so that we don't record two
descriptors
> of the same type if Compiler::always_optimize() is true.

Done.

[Florian Schneider, 2015-12-15 18:02:34]

lgtm

https://codereview.chromium.org/1513883002/diff/110001/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1513883002/diff/110001/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:257: if (FLAG_precompilation &&
Maybe use Compiler::always_optimize() like in other places in the optimizer.

[srdjan, 2015-12-15 18:28:25]

https://codereview.chromium.org/1513883002/diff/110001/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1513883002/diff/110001/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:257: if (FLAG_precompilation &&
On 2015/12/15 18:02:34, Florian Schneider wrote:
> Maybe use Compiler::always_optimize() like in other places in the optimizer.

if (Compiler::always_optimize &&
    isolate()->object_store()->unique_dynamic_targets() != Array::null()

[srdjan, 2015-12-15 20:34:58]

Description was changed from

==========
Polymorphic calls in precompilation invoke megamorphic calls when tests fail
(instead of deoptimizing). Move the megamorphic call into a slow path stub.
Cleanups.
Allow truning off speculative inlining if --max_speculative_inlining_attempts
<=0

BUG=
==========

to

==========
Polymorphic calls in precompilation invoke megamorphic calls when tests fail
(instead of deoptimizing). Move the megamorphic call into a slow path stub.
Cleanups.
Allow truning off speculative inlining if --max_speculative_inlining_attempts
<=0

BUG=
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3a46cc28b775c5a9df0ea40133f78e18e2f873be
==========

[srdjan, 2015-12-15 20:34:59]

Committed patchset #9 (id:150001) manually as
3a46cc28b775c5a9df0ea40133f78e18e2f873be (presubmit successful).