Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: mojo/dart/packages/mojo_apptest/lib/apptest.dart

Issue 1513853002: Dart: Uses tearDownAll in mojo_apptest. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/packages/mojo_apptest/CHANGELOG.md ('k') | mojo/dart/packages/mojo_apptest/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/packages/mojo_apptest/lib/apptest.dart
diff --git a/mojo/dart/packages/mojo_apptest/lib/apptest.dart b/mojo/dart/packages/mojo_apptest/lib/apptest.dart
index 7b4af0c9b5d73e344f7ad61d008966c475989277..9a260bdf1d1e7706d82d106012db9ab0b92adc38 100644
--- a/mojo/dart/packages/mojo_apptest/lib/apptest.dart
+++ b/mojo/dart/packages/mojo_apptest/lib/apptest.dart
@@ -36,10 +36,8 @@ class _ConnectionToShellApplication extends Application {
testFunction(this, url);
}
});
- // Append a final test to terminate shell connection.
- // TODO(johnmccutchan): Remove this once package 'test' supports a global
- // tearDown callback.
- test('TERMINATE SHELL CONNECTION', () async {
+
+ tearDownAll(() async {
await close();
MojoHandle.reportLeakedHandles();
});
« no previous file with comments | « mojo/dart/packages/mojo_apptest/CHANGELOG.md ('k') | mojo/dart/packages/mojo_apptest/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698