Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1513843006: Remove --harmony-array-includes flag (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
domenic, Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-array-includes flag Array.prototype.includes shipped in Chrome 47. Committed: https://crrev.com/a229c9b94fc81b28cae183b38c6839c053d4bef7 Cr-Commit-Position: refs/heads/master@{#32818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1074 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/array.js View 5 chunks +46 lines, -1 line 0 comments Download
D src/js/harmony-array-includes.js View 1 chunk +0 lines, -118 lines 0 comments Download
M src/js/typedarray.js View 4 chunks +14 lines, -0 lines 0 comments Download
A + test/mjsunit/es7/array-includes.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es7/array-includes-to-object-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es7/array-includes-to-object-strict.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es7/typed-array-includes.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/array-includes.js View 1 chunk +0 lines, -677 lines 0 comments Download
D test/mjsunit/harmony/array-includes-to-object-sloppy.js View 1 chunk +0 lines, -29 lines 0 comments Download
D test/mjsunit/harmony/array-includes-to-object-strict.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/mjsunit/harmony/typed-array-includes.js View 1 chunk +0 lines, -203 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
5 years ago (2015-12-12 00:41:29 UTC) #2
Dan Ehrenberg
lgtm
5 years ago (2015-12-12 00:42:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513843006/1
5 years ago (2015-12-12 00:44:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 01:03:33 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-12 01:04:19 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a229c9b94fc81b28cae183b38c6839c053d4bef7
Cr-Commit-Position: refs/heads/master@{#32818}

Powered by Google App Engine
This is Rietveld 408576698