Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151383003: Updates to wallet for i18n (Closed)

Created:
6 years, 10 months ago by Evan Stade
Modified:
6 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix blasted unit tests #

Total comments: 11

Patch Set 4 : . #

Patch Set 5 : a couple more mechanical updates #

Patch Set 6 : fix android compile #

Patch Set 7 : retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -147 lines) Patch
M chrome/browser/ui/android/autofill/autofill_dialog_result.cc View 1 2 3 4 5 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/full_wallet_unittest.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/content/browser/wallet/instrument_unittest.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.h View 1 2 7 chunks +28 lines, -17 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address.cc View 1 2 12 chunks +81 lines, -37 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_address_unittest.cc View 1 2 20 chunks +70 lines, -31 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 2 8 chunks +23 lines, -8 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_items_unittest.cc View 1 2 12 chunks +40 lines, -20 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_test_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_test_util.cc View 1 2 2 chunks +41 lines, -27 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Evan Stade
postaladdress.proto has locality_name, dependent_locality_name, sorting_code, [...] whereas Address in wallet_entities.proto decides to use city, state, ...
6 years, 10 months ago (2014-02-12 02:07:57 UTC) #1
Dan Beam
lgtm w/nits https://codereview.chromium.org/151383003/diff/270002/components/autofill/content/browser/wallet/wallet_address.cc File components/autofill/content/browser/wallet/wallet_address.cc (right): https://codereview.chromium.org/151383003/diff/270002/components/autofill/content/browser/wallet/wallet_address.cc#newcode53 components/autofill/content/browser/wallet/wallet_address.cc:53: DVLOG(1) << "Response from Google Wallet missing ...
6 years, 10 months ago (2014-02-12 21:34:32 UTC) #2
Evan Stade
https://codereview.chromium.org/151383003/diff/270002/components/autofill/content/browser/wallet/wallet_address.cc File components/autofill/content/browser/wallet/wallet_address.cc (right): https://codereview.chromium.org/151383003/diff/270002/components/autofill/content/browser/wallet/wallet_address.cc#newcode53 components/autofill/content/browser/wallet/wallet_address.cc:53: DVLOG(1) << "Response from Google Wallet missing sorting code"; ...
6 years, 10 months ago (2014-02-12 23:32:13 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 10 months ago (2014-02-12 23:32:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/151383003/380001
6 years, 10 months ago (2014-02-12 23:39:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 00:46:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=228845
6 years, 10 months ago (2014-02-13 00:46:48 UTC) #7
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 10 months ago (2014-02-13 20:54:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/151383003/810001
6 years, 10 months ago (2014-02-13 20:56:11 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 22:12:11 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=150499
6 years, 10 months ago (2014-02-13 22:12:12 UTC) #11
Evan Stade
aruslan TBR for android changes.
6 years, 10 months ago (2014-02-14 22:10:04 UTC) #12
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 10 months ago (2014-02-14 22:12:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/151383003/1160001
6 years, 10 months ago (2014-02-14 22:17:53 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 23:39:06 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, interactive_ui_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264736
6 years, 10 months ago (2014-02-14 23:39:07 UTC) #16
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 10 months ago (2014-02-14 23:46:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/151383003/1160001
6 years, 10 months ago (2014-02-14 23:59:14 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 04:56:30 UTC) #19
Message was sent while issue was closed. 
Change committed as 251520

Powered by Google App Engine
This is Rietveld 408576698