Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart

Issue 15138002: Added tests to previously broken functionality and added null checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
diff --git a/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart b/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
index 80671f8cf067acb2a893015a36fee3d550bbb7e4..1f18147a44da2d26bd9fa147b9bf69e71c5e356d 100644
--- a/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
+++ b/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart
@@ -900,19 +900,19 @@ class ObjectStore native "IDBObjectStore" {
@DomName('IDBObjectStore.createIndex')
@DocsEditable
Index $dom_createIndex(String name, keyPath, [Map options]) {
- if ((keyPath is List<String> || keyPath == null) && !?options) {
+ if (keyPath is List<String> && keyPath != null && !?options) {
List keyPath_1 = convertDartToNative_StringArray(keyPath);
return _$dom_createIndex_1(name, keyPath_1);
}
- if ((keyPath is List<String> || keyPath == null)) {
+ if (keyPath is List<String> && keyPath != null) {
blois 2013/05/13 21:09:16 keyPath is List<String> && keyPath != null is over
List keyPath_2 = convertDartToNative_StringArray(keyPath);
var options_3 = convertDartToNative_Dictionary(options);
return _$dom_createIndex_2(name, keyPath_2, options_3);
}
- if ((keyPath is String || keyPath == null) && !?options) {
+ if (keyPath is String && keyPath != null && !?options) {
return _$dom_createIndex_3(name, keyPath);
}
- if ((keyPath is String || keyPath == null)) {
+ if (keyPath is String && keyPath != null) {
var options_4 = convertDartToNative_Dictionary(options);
return _$dom_createIndex_4(name, keyPath, options_4);
}

Powered by Google App Engine
This is Rietveld 408576698