Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 15138002: Added tests to previously broken functionality and added null checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Correctly check for position. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /// The Dart HTML library. 1 /// The Dart HTML library.
2 library dart.dom.html; 2 library dart.dom.html;
3 3
4 import 'dart:async'; 4 import 'dart:async';
5 import 'dart:collection'; 5 import 'dart:collection';
6 import 'dart:_collection-dev' hide Symbol; 6 import 'dart:_collection-dev' hide Symbol;
7 import 'dart:html_common'; 7 import 'dart:html_common';
8 import 'dart:indexed_db'; 8 import 'dart:indexed_db';
9 import 'dart:isolate'; 9 import 'dart:isolate';
10 import 'dart:json' as json; 10 import 'dart:json' as json;
(...skipping 1193 matching lines...) Expand 10 before | Expand all | Expand 10 after
1204 void moveTo(num x, num y) native; 1204 void moveTo(num x, num y) native;
1205 1205
1206 @DomName('CanvasRenderingContext2D.putImageData') 1206 @DomName('CanvasRenderingContext2D.putImageData')
1207 @DocsEditable 1207 @DocsEditable
1208 void putImageData(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY , num dirtyWidth, num dirtyHeight]) { 1208 void putImageData(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY , num dirtyWidth, num dirtyHeight]) {
1209 if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) { 1209 if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
1210 var imagedata_1 = _convertDartToNative_ImageData(imagedata); 1210 var imagedata_1 = _convertDartToNative_ImageData(imagedata);
1211 _putImageData_1(imagedata_1, dx, dy); 1211 _putImageData_1(imagedata_1, dx, dy);
1212 return; 1212 return;
1213 } 1213 }
1214 var imagedata_2 = _convertDartToNative_ImageData(imagedata); 1214 if (dirtyX != null && dirtyY != null && dirtyWidth != null && dirtyHeight != null) {
1215 _putImageData_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight ); 1215 var imagedata_2 = _convertDartToNative_ImageData(imagedata);
1216 return; 1216 _putImageData_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeig ht);
1217 return;
1218 }
1217 throw new ArgumentError("Incorrect number or type of arguments"); 1219 throw new ArgumentError("Incorrect number or type of arguments");
1218 } 1220 }
1219 @JSName('putImageData') 1221 @JSName('putImageData')
1220 @DomName('CanvasRenderingContext2D.putImageData') 1222 @DomName('CanvasRenderingContext2D.putImageData')
1221 @DocsEditable 1223 @DocsEditable
1222 void _putImageData_1(imagedata, dx, dy) native; 1224 void _putImageData_1(imagedata, dx, dy) native;
1223 @JSName('putImageData') 1225 @JSName('putImageData')
1224 @DomName('CanvasRenderingContext2D.putImageData') 1226 @DomName('CanvasRenderingContext2D.putImageData')
1225 @DocsEditable 1227 @DocsEditable
1226 void _putImageData_2(imagedata, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeigh t) native; 1228 void _putImageData_2(imagedata, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeigh t) native;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
1299 @DocsEditable 1301 @DocsEditable
1300 @SupportedBrowser(SupportedBrowser.CHROME) 1302 @SupportedBrowser(SupportedBrowser.CHROME)
1301 @SupportedBrowser(SupportedBrowser.SAFARI) 1303 @SupportedBrowser(SupportedBrowser.SAFARI)
1302 @Experimental 1304 @Experimental
1303 void putImageDataHD(ImageData imagedata, num dx, num dy, [num dirtyX, num dirt yY, num dirtyWidth, num dirtyHeight]) { 1305 void putImageDataHD(ImageData imagedata, num dx, num dy, [num dirtyX, num dirt yY, num dirtyWidth, num dirtyHeight]) {
1304 if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) { 1306 if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
1305 var imagedata_1 = _convertDartToNative_ImageData(imagedata); 1307 var imagedata_1 = _convertDartToNative_ImageData(imagedata);
1306 _putImageDataHD_1(imagedata_1, dx, dy); 1308 _putImageDataHD_1(imagedata_1, dx, dy);
1307 return; 1309 return;
1308 } 1310 }
1309 var imagedata_2 = _convertDartToNative_ImageData(imagedata); 1311 if (dirtyX != null && dirtyY != null && dirtyWidth != null && dirtyHeight != null) {
1310 _putImageDataHD_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeig ht); 1312 var imagedata_2 = _convertDartToNative_ImageData(imagedata);
1311 return; 1313 _putImageDataHD_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHe ight);
1314 return;
1315 }
1312 throw new ArgumentError("Incorrect number or type of arguments"); 1316 throw new ArgumentError("Incorrect number or type of arguments");
1313 } 1317 }
1314 @JSName('webkitPutImageDataHD') 1318 @JSName('webkitPutImageDataHD')
1315 @DomName('CanvasRenderingContext2D.webkitPutImageDataHD') 1319 @DomName('CanvasRenderingContext2D.webkitPutImageDataHD')
1316 @DocsEditable 1320 @DocsEditable
1317 @SupportedBrowser(SupportedBrowser.CHROME) 1321 @SupportedBrowser(SupportedBrowser.CHROME)
1318 @SupportedBrowser(SupportedBrowser.SAFARI) 1322 @SupportedBrowser(SupportedBrowser.SAFARI)
1319 @Experimental 1323 @Experimental
1320 void _putImageDataHD_1(imagedata, dx, dy) native; 1324 void _putImageDataHD_1(imagedata, dx, dy) native;
1321 @JSName('webkitPutImageDataHD') 1325 @JSName('webkitPutImageDataHD')
(...skipping 26974 matching lines...) Expand 10 before | Expand all | Expand 10 after
28296 _position = nextPosition; 28300 _position = nextPosition;
28297 return true; 28301 return true;
28298 } 28302 }
28299 _current = null; 28303 _current = null;
28300 _position = _array.length; 28304 _position = _array.length;
28301 return false; 28305 return false;
28302 } 28306 }
28303 28307
28304 T get current => _current; 28308 T get current => _current;
28305 } 28309 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dartium/indexed_db_dartium.dart » ('j') | sdk/lib/web_gl/dart2js/web_gl_dart2js.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698