Added tests to previously broken functionality and added null checks.

sdk/lib/indexed_db/dartium/indexed_db_dartium.dart

 library dart.dom.indexed_db;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:html_common';
 import 'dart:nativewrappers';
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
@@ skipping 453 matching lines @@
   ObjectStore get objectStore native "IDBIndex_objectStore_Getter";
 
   @DomName('IDBIndex.unique')
   @DocsEditable
   bool get unique native "IDBIndex_unique_Getter";
 
   Request $dom_count([key_OR_range]) {
     if ((key_OR_range is KeyRange || key_OR_range == null)) {
       return _count_1(key_OR_range);
     }
-    if (?key_OR_range) {
+    if (?key_OR_range && key_OR_range != null) {
       return _count_2(key_OR_range);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _count_1(key_OR_range) native "IDBIndex__count_1_Callback";
 
   Request _count_2(key_OR_range) native "IDBIndex__count_2_Callback";
 
   Request $dom_get(key) {
     if ((key is KeyRange || key == null)) {
       return _get_1(key);
     }
-    if (?key) {
+    if (?key && key != null) {

[Anton Muhin, 2013/05/21 13:24:08]

why there are both checks?

[Andrei Mouravski, 2013/05/21 18:39:14]

Because removing the question mark is in the next CL. This currently is not a
problem since the other case is true when key is null.

On 2013/05/21 13:24:08, Anton Muhin wrote:

       return _get_2(key);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _get_1(key) native "IDBIndex__get_1_Callback";
 
   Request _get_2(key) native "IDBIndex__get_2_Callback";
 
   Request $dom_getKey(key) {
     if ((key is KeyRange || key == null)) {
       return _getKey_1(key);
     }
-    if (?key) {
+    if (?key && key != null) {
       return _getKey_2(key);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _getKey_1(key) native "IDBIndex__getKey_1_Callback";
 
   Request _getKey_2(key) native "IDBIndex__getKey_2_Callback";
 
   Request $dom_openCursor([key_OR_range, String direction]) {
     if ((key_OR_range is KeyRange || key_OR_range == null) && (direction is String || direction == null)) {
       return _openCursor_1(key_OR_range, direction);
     }
-    if (?key_OR_range && (direction is String || direction == null)) {
+    if (?key_OR_range && key_OR_range != null && (direction is String || direction == null)) {
       return _openCursor_2(key_OR_range, direction);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _openCursor_1(key_OR_range, direction) native "IDBIndex__openCursor_1_Callback";
 
   Request _openCursor_2(key_OR_range, direction) native "IDBIndex__openCursor_2_Callback";
 
   Request $dom_openKeyCursor([key_OR_range, String direction]) {
     if ((key_OR_range is KeyRange || key_OR_range == null) && (direction is String || direction == null)) {
       return _openKeyCursor_1(key_OR_range, direction);
     }
-    if (?key_OR_range && (direction is String || direction == null)) {
+    if (?key_OR_range && key_OR_range != null && (direction is String || direction == null)) {
       return _openKeyCursor_2(key_OR_range, direction);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _openKeyCursor_1(key_OR_range, direction) native "IDBIndex__openKeyCursor_1_Callback";
 
   Request _openKeyCursor_2(key_OR_range, direction) native "IDBIndex__openKeyCursor_2_Callback";
 
 }
@@ skipping 223 matching lines @@
   Request $dom_add(Object value, [Object key]) native "IDBObjectStore_add_Callback";
 
   @DomName('IDBObjectStore.clear')
   @DocsEditable
   Request $dom_clear() native "IDBObjectStore_clear_Callback";
 
   Request $dom_count([key_OR_range]) {
     if ((key_OR_range is KeyRange || key_OR_range == null)) {
       return _count_1(key_OR_range);
     }
-    if (?key_OR_range) {
+    if (?key_OR_range && key_OR_range != null) {
       return _count_2(key_OR_range);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _count_1(key_OR_range) native "IDBObjectStore__count_1_Callback";
 
   Request _count_2(key_OR_range) native "IDBObjectStore__count_2_Callback";
 
   Index $dom_createIndex(String name, keyPath, [Map options]) {
     if ((name is String || name == null) && (keyPath is List<String> || keyPath == null) && (options is Map || options == null)) {
       return _createIndex_1(name, keyPath, options);
     }
     if ((name is String || name == null) && (keyPath is String || keyPath == null) && (options is Map || options == null)) {
       return _createIndex_2(name, keyPath, options);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Index _createIndex_1(name, keyPath, options) native "IDBObjectStore__createIndex_1_Callback";
 
   Index _createIndex_2(name, keyPath, options) native "IDBObjectStore__createIndex_2_Callback";
 
   Request $dom_delete(key_OR_keyRange) {
     if ((key_OR_keyRange is KeyRange || key_OR_keyRange == null)) {
       return _delete_1(key_OR_keyRange);
     }
-    if (?key_OR_keyRange) {
+    if (?key_OR_keyRange && key_OR_keyRange != null) {
       return _delete_2(key_OR_keyRange);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _delete_1(key_OR_keyRange) native "IDBObjectStore__delete_1_Callback";
 
   Request _delete_2(key_OR_keyRange) native "IDBObjectStore__delete_2_Callback";
 
   @DomName('IDBObjectStore.deleteIndex')
   @DocsEditable
   void deleteIndex(String name) native "IDBObjectStore_deleteIndex_Callback";
 
   Request $dom_get(key) {
     if ((key is KeyRange || key == null)) {
       return _get_1(key);
     }
-    if (?key) {
+    if (?key && key != null) {
       return _get_2(key);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _get_1(key) native "IDBObjectStore__get_1_Callback";
 
   Request _get_2(key) native "IDBObjectStore__get_2_Callback";
 
   @DomName('IDBObjectStore.index')
   @DocsEditable
   Index index(String name) native "IDBObjectStore_index_Callback";
 
   Request $dom_openCursor([key_OR_range, String direction]) {
     if ((key_OR_range is KeyRange || key_OR_range == null) && (direction is String || direction == null)) {
       return _openCursor_1(key_OR_range, direction);
     }
-    if (?key_OR_range && (direction is String || direction == null)) {
+    if (?key_OR_range && key_OR_range != null && (direction is String || direction == null)) {
       return _openCursor_2(key_OR_range, direction);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
 
   Request _openCursor_1(key_OR_range, direction) native "IDBObjectStore__openCursor_1_Callback";
 
   Request _openCursor_2(key_OR_range, direction) native "IDBObjectStore__openCursor_2_Callback";
 
   @DomName('IDBObjectStore.put')
@@ skipping 253 matching lines @@
 
 // WARNING: Do not edit - generated code.
 
 
 @DocsEditable
 @DomName('IDBAny')
 abstract class _IDBAny extends NativeFieldWrapperClass1 {
   _IDBAny.internal();
 
 }