Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: sdk/lib/web_audio/dartium/web_audio_dartium.dart

Issue 15138002: Added tests to previously broken functionality and added null checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 library dart.dom.web_audio; 1 library dart.dom.web_audio;
2 2
3 import 'dart:async'; 3 import 'dart:async';
4 import 'dart:collection'; 4 import 'dart:collection';
5 import 'dart:_collection-dev'; 5 import 'dart:_collection-dev';
6 import 'dart:html'; 6 import 'dart:html';
7 import 'dart:html_common'; 7 import 'dart:html_common';
8 import 'dart:nativewrappers'; 8 import 'dart:nativewrappers';
9 import 'dart:typed_data'; 9 import 'dart:typed_data';
10 // DO NOT EDIT 10 // DO NOT EDIT
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 189
190 @DomName('AudioBufferSourceNode.playbackRate') 190 @DomName('AudioBufferSourceNode.playbackRate')
191 @DocsEditable 191 @DocsEditable
192 AudioParam get playbackRate native "AudioBufferSourceNode_playbackRate_Getter" ; 192 AudioParam get playbackRate native "AudioBufferSourceNode_playbackRate_Getter" ;
193 193
194 @DomName('AudioBufferSourceNode.playbackState') 194 @DomName('AudioBufferSourceNode.playbackState')
195 @DocsEditable 195 @DocsEditable
196 int get playbackState native "AudioBufferSourceNode_playbackState_Getter"; 196 int get playbackState native "AudioBufferSourceNode_playbackState_Getter";
197 197
198 void start(num when, [num grainOffset, num grainDuration]) { 198 void start(num when, [num grainOffset, num grainDuration]) {
199 if ((when is num || when == null) && !?grainOffset && !?grainDuration) { 199 if (when is num && !?grainOffset && !?grainDuration) {
blois 2013/05/13 21:09:16 when is when not a num?
200 _start_1(when); 200 _start_1(when);
201 return; 201 return;
202 } 202 }
203 if ((when is num || when == null) && (grainOffset is num || grainOffset == n ull) && !?grainDuration) { 203 if (grainOffset is num && grainOffset != null && when is num && !?grainDurat ion) {
204 _start_2(when, grainOffset); 204 _start_2(when, grainOffset);
205 return; 205 return;
206 } 206 }
207 if ((when is num || when == null) && (grainOffset is num || grainOffset == n ull) && (grainDuration is num || grainDuration == null)) { 207 if (grainDuration is num && grainDuration != null && grainOffset is num && g rainOffset != null && when is num) {
208 _start_3(when, grainOffset, grainDuration); 208 _start_3(when, grainOffset, grainDuration);
209 return; 209 return;
210 } 210 }
211 throw new ArgumentError("Incorrect number or type of arguments"); 211 throw new ArgumentError("Incorrect number or type of arguments");
212 } 212 }
213 213
214 void _start_1(when) native "AudioBufferSourceNode__start_1_Callback"; 214 void _start_1(when) native "AudioBufferSourceNode__start_1_Callback";
215 215
216 void _start_2(when, grainOffset) native "AudioBufferSourceNode__start_2_Callba ck"; 216 void _start_2(when, grainOffset) native "AudioBufferSourceNode__start_2_Callba ck";
217 217
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 264
265 @DomName('AudioContext.createAnalyser') 265 @DomName('AudioContext.createAnalyser')
266 @DocsEditable 266 @DocsEditable
267 AnalyserNode createAnalyser() native "AudioContext_createAnalyser_Callback"; 267 AnalyserNode createAnalyser() native "AudioContext_createAnalyser_Callback";
268 268
269 @DomName('AudioContext.createBiquadFilter') 269 @DomName('AudioContext.createBiquadFilter')
270 @DocsEditable 270 @DocsEditable
271 BiquadFilterNode createBiquadFilter() native "AudioContext_createBiquadFilter_ Callback"; 271 BiquadFilterNode createBiquadFilter() native "AudioContext_createBiquadFilter_ Callback";
272 272
273 AudioBuffer createBuffer(buffer_OR_numberOfChannels, mixToMono_OR_numberOfFram es, [num sampleRate]) { 273 AudioBuffer createBuffer(buffer_OR_numberOfChannels, mixToMono_OR_numberOfFram es, [num sampleRate]) {
274 if ((buffer_OR_numberOfChannels is int || buffer_OR_numberOfChannels == null ) && (mixToMono_OR_numberOfFrames is int || mixToMono_OR_numberOfFrames == null) && (sampleRate is num || sampleRate == null)) { 274 if (sampleRate is num && sampleRate != null && mixToMono_OR_numberOfFrames i s int && mixToMono_OR_numberOfFrames != null && buffer_OR_numberOfChannels is in t && buffer_OR_numberOfChannels != null) {
275 return _createBuffer_1(buffer_OR_numberOfChannels, mixToMono_OR_numberOfFr ames, sampleRate); 275 return _createBuffer_1(buffer_OR_numberOfChannels, mixToMono_OR_numberOfFr ames, sampleRate);
276 } 276 }
277 if ((buffer_OR_numberOfChannels is ByteBuffer || buffer_OR_numberOfChannels == null) && (mixToMono_OR_numberOfFrames is bool || mixToMono_OR_numberOfFrames == null) && !?sampleRate) { 277 if (mixToMono_OR_numberOfFrames is bool && mixToMono_OR_numberOfFrames != nu ll && buffer_OR_numberOfChannels is ByteBuffer && buffer_OR_numberOfChannels != null && !?sampleRate) {
278 return _createBuffer_2(buffer_OR_numberOfChannels, mixToMono_OR_numberOfFr ames); 278 return _createBuffer_2(buffer_OR_numberOfChannels, mixToMono_OR_numberOfFr ames);
279 } 279 }
280 throw new ArgumentError("Incorrect number or type of arguments"); 280 throw new ArgumentError("Incorrect number or type of arguments");
281 } 281 }
282 282
283 AudioBuffer _createBuffer_1(buffer_OR_numberOfChannels, mixToMono_OR_numberOfF rames, sampleRate) native "AudioContext__createBuffer_1_Callback"; 283 AudioBuffer _createBuffer_1(buffer_OR_numberOfChannels, mixToMono_OR_numberOfF rames, sampleRate) native "AudioContext__createBuffer_1_Callback";
284 284
285 AudioBuffer _createBuffer_2(buffer_OR_numberOfChannels, mixToMono_OR_numberOfF rames) native "AudioContext__createBuffer_2_Callback"; 285 AudioBuffer _createBuffer_2(buffer_OR_numberOfChannels, mixToMono_OR_numberOfF rames) native "AudioContext__createBuffer_2_Callback";
286 286
287 @DomName('AudioContext.createBufferSource') 287 @DomName('AudioContext.createBufferSource')
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 490
491 @DomName('AudioNode.numberOfInputs') 491 @DomName('AudioNode.numberOfInputs')
492 @DocsEditable 492 @DocsEditable
493 int get numberOfInputs native "AudioNode_numberOfInputs_Getter"; 493 int get numberOfInputs native "AudioNode_numberOfInputs_Getter";
494 494
495 @DomName('AudioNode.numberOfOutputs') 495 @DomName('AudioNode.numberOfOutputs')
496 @DocsEditable 496 @DocsEditable
497 int get numberOfOutputs native "AudioNode_numberOfOutputs_Getter"; 497 int get numberOfOutputs native "AudioNode_numberOfOutputs_Getter";
498 498
499 void connect(destination, int output, [int input]) { 499 void connect(destination, int output, [int input]) {
500 if ((destination is AudioNode || destination == null) && (output is int || o utput == null) && (input is int || input == null)) { 500 if (input is int && input != null && output is int && destination is AudioNo de && destination != null) {
501 _connect_1(destination, output, input); 501 _connect_1(destination, output, input);
502 return; 502 return;
503 } 503 }
504 if ((destination is AudioParam || destination == null) && (output is int || output == null) && !?input) { 504 if (output is int && destination is AudioParam && destination != null && !?i nput) {
505 _connect_2(destination, output); 505 _connect_2(destination, output);
506 return; 506 return;
507 } 507 }
508 throw new ArgumentError("Incorrect number or type of arguments"); 508 throw new ArgumentError("Incorrect number or type of arguments");
509 } 509 }
510 510
511 void _connect_1(destination, output, input) native "AudioNode__connect_1_Callb ack"; 511 void _connect_1(destination, output, input) native "AudioNode__connect_1_Callb ack";
512 512
513 void _connect_2(destination, output) native "AudioNode__connect_2_Callback"; 513 void _connect_2(destination, output) native "AudioNode__connect_2_Callback";
514 514
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
1172 1172
1173 // WARNING: Do not edit - generated code. 1173 // WARNING: Do not edit - generated code.
1174 1174
1175 1175
1176 @DocsEditable 1176 @DocsEditable
1177 @DomName('WaveTable') 1177 @DomName('WaveTable')
1178 class WaveTable extends NativeFieldWrapperClass1 { 1178 class WaveTable extends NativeFieldWrapperClass1 {
1179 WaveTable.internal(); 1179 WaveTable.internal();
1180 1180
1181 } 1181 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698