Added tests to previously broken functionality and added null checks.

sdk/lib/html/dart2js/html_dart2js.dart

 /// The Dart HTML library.
 library dart.dom.html;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:_collection-dev' hide Symbol;
 import 'dart:html_common';
 import 'dart:indexed_db';
 import 'dart:isolate';
 import 'dart:json' as json;
@@ skipping 1185 matching lines @@
   void moveTo(num x, num y) native;
 
   @DomName('CanvasRenderingContext2D.putImageData')
   @DocsEditable
   void putImageData(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY, num dirtyWidth, num dirtyHeight]) {
     if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
       var imagedata_1 = _convertDartToNative_ImageData(imagedata);
       _putImageData_1(imagedata_1, dx, dy);
       return;
     }
-    var imagedata_2 = _convertDartToNative_ImageData(imagedata);
-    _putImageData_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight);
-    return;
+    if (dirtyHeight != null && dirtyWidth != null && dirtyY != null && dirtyX != null) {
+      var imagedata_2 = _convertDartToNative_ImageData(imagedata);
+      _putImageData_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight);
+      return;
+    }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
   @JSName('putImageData')
   @DomName('CanvasRenderingContext2D.putImageData')
   @DocsEditable
   void _putImageData_1(imagedata, dx, dy) native;
   @JSName('putImageData')
   @DomName('CanvasRenderingContext2D.putImageData')
   @DocsEditable
   void _putImageData_2(imagedata, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight) native;
@@ skipping 72 matching lines @@
   @DocsEditable
   @SupportedBrowser(SupportedBrowser.CHROME)
   @SupportedBrowser(SupportedBrowser.SAFARI)
   @Experimental
   void putImageDataHD(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY, num dirtyWidth, num dirtyHeight]) {
     if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
       var imagedata_1 = _convertDartToNative_ImageData(imagedata);
       _putImageDataHD_1(imagedata_1, dx, dy);
       return;
     }
-    var imagedata_2 = _convertDartToNative_ImageData(imagedata);
-    _putImageDataHD_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight);
-    return;
+    if (dirtyHeight != null && dirtyWidth != null && dirtyY != null && dirtyX != null) {
+      var imagedata_2 = _convertDartToNative_ImageData(imagedata);
+      _putImageDataHD_2(imagedata_2, dx, dy, dirtyX, dirtyY, dirtyWidth, dirtyHeight);
+      return;
+    }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
   @JSName('webkitPutImageDataHD')
   @DomName('CanvasRenderingContext2D.webkitPutImageDataHD')
   @DocsEditable
   @SupportedBrowser(SupportedBrowser.CHROME)
   @SupportedBrowser(SupportedBrowser.SAFARI)
   @Experimental
   void _putImageDataHD_1(imagedata, dx, dy) native;
   @JSName('webkitPutImageDataHD')
@@ skipping 12326 matching lines @@
   @DomName('MediaStream.removetrackEvent')
   @DocsEditable
   static const EventStreamProvider<Event> removeTrackEvent = const EventStreamProvider<Event>('removetrack');
 
   @DomName('MediaStream.MediaStream')
   @DocsEditable
   factory MediaStream([stream_OR_tracks]) {
     if (!?stream_OR_tracks) {
       return MediaStream._create_1();
     }
-    if ((stream_OR_tracks is MediaStream || stream_OR_tracks == null)) {
+    if (stream_OR_tracks is MediaStream && stream_OR_tracks != null) {
       return MediaStream._create_2(stream_OR_tracks);
     }
-    if ((stream_OR_tracks is List<MediaStreamTrack> || stream_OR_tracks == null)) {
+    if (stream_OR_tracks is List<MediaStreamTrack> && stream_OR_tracks != null) {
       return MediaStream._create_3(stream_OR_tracks);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
   static MediaStream _create_1() => JS('MediaStream', 'new MediaStream()');
   static MediaStream _create_2(stream_OR_tracks) => JS('MediaStream', 'new MediaStream(#)', stream_OR_tracks);
   static MediaStream _create_3(stream_OR_tracks) => JS('MediaStream', 'new MediaStream(#)', stream_OR_tracks);
 
   @DomName('MediaStream.ended')
   @DocsEditable
@@ skipping 2364 matching lines @@
 @DocsEditable
 @DomName('Path')
 class Path native "Path" {
 
   @DomName('Path.DOMPath')
   @DocsEditable
   factory Path([path_OR_text]) {
     if (!?path_OR_text) {
       return Path._create_1();
     }
-    if ((path_OR_text is Path || path_OR_text == null)) {
+    if (path_OR_text is Path && path_OR_text != null) {
       return Path._create_2(path_OR_text);
     }
-    if ((path_OR_text is String || path_OR_text == null)) {
+    if (path_OR_text is String && path_OR_text != null) {
       return Path._create_3(path_OR_text);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
   static Path _create_1() => JS('Path', 'new Path()');
   static Path _create_2(path_OR_text) => JS('Path', 'new Path(#)', path_OR_text);
   static Path _create_3(path_OR_text) => JS('Path', 'new Path(#)', path_OR_text);
 
   @DomName('Path.arc')
   @DocsEditable
@@ skipping 4664 matching lines @@
   @DocsEditable
   static const EventStreamProvider<MessageEvent> messageEvent = const EventStreamProvider<MessageEvent>('message');
 
   @DomName('WebSocket.openEvent')
   @DocsEditable
   static const EventStreamProvider<Event> openEvent = const EventStreamProvider<Event>('open');
 
   @DomName('WebSocket.WebSocket')
   @DocsEditable
   factory WebSocket(String url, [protocol_OR_protocols]) {
-    if ((url is String || url == null) && !?protocol_OR_protocols) {
+    if (url is String && !?protocol_OR_protocols) {
       return WebSocket._create_1(url);
     }
-    if ((url is String || url == null) && (protocol_OR_protocols is List<String> || protocol_OR_protocols == null)) {
+    if (protocol_OR_protocols is List<String> && protocol_OR_protocols != null && url is String) {

[blois, 2013/05/13 21:09:16]

why are the "url is String" checks here- it's typed and it's not optional.

[Andrei Mouravski, 2013/05/14 00:00:53]

Because that's what the code does? It was being checked before, too.

       return WebSocket._create_2(url, protocol_OR_protocols);
     }
-    if ((url is String || url == null) && (protocol_OR_protocols is String || protocol_OR_protocols == null)) {
+    if (protocol_OR_protocols is String && protocol_OR_protocols != null && url is String) {
       return WebSocket._create_3(url, protocol_OR_protocols);
     }
     throw new ArgumentError("Incorrect number or type of arguments");
   }
   static WebSocket _create_1(url) => JS('WebSocket', 'new WebSocket(#)', url);
   static WebSocket _create_2(url, protocol_OR_protocols) => JS('WebSocket', 'new WebSocket(#,#)', url, protocol_OR_protocols);
   static WebSocket _create_3(url, protocol_OR_protocols) => JS('WebSocket', 'new WebSocket(#,#)', url, protocol_OR_protocols);
 
   /// Checks if this type is supported on the current platform.
   static bool get supported => JS('bool', 'typeof window.WebSocket != "undefined"');
@@ skipping 7208 matching lines @@
       _position = nextPosition;
       return true;
     }
     _current = null;
     _position = _array.length;
     return false;
   }
 
   T get current => _current;
 }