Added tests to previously broken functionality and added null checks.

tests/html/canvasrenderingcontext2d_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library canvas_rendering_context_2d_test; import '../../pkg/unittest/lib/unittest.dart';
 import '../../pkg/unittest/lib/html_individual_config.dart';
 import 'dart:html';
 import 'dart:math';
 
 // Some rounding errors in the browsers.
@@ skipping 141 matching lines @@
     test('fillStyle linearGradient', () {
       var gradient = context.createLinearGradient(0,0,20,20);
       gradient.addColorStop(0,'red');
       gradient.addColorStop(1,'blue');
       context.fillStyle = gradient;
       context.fillRect(0, 0, canvas.width, canvas.height);
       expect(context.fillStyle is CanvasGradient, isTrue);
     });
 
     test('putImageData', () {
+      context.fillStyle = 'green';
+      context.fillRect(0, 0, canvas.width, canvas.height);
+
       ImageData expectedData = context.getImageData(0, 0, 10, 10);
       expectedData.data[0] = 25;
       expectedData.data[1] = 65;
       expectedData.data[2] = 255;
       // Set alpha to 255 to make the pixels show up.
       expectedData.data[3] = 255;
-      context.fillStyle = 'green';
-      context.fillRect(0, 0, canvas.width, canvas.height);
 
       context.putImageData(expectedData, 0, 0);
 
       var resultingData = context.getImageData(0, 0, 10, 10);
       // Make sure that we read back what we wrote.
       expect(resultingData.data, expectedData.data);
     });
+
+    test('putImageData dirty rectangle', () {
+      context.fillStyle = 'green';
+      context.fillRect(0, 0, canvas.width, canvas.height);
+
+      ImageData drawnData = context.getImageData(0, 0, 10, 10);
+      drawnData.data[0] = 25;

[Anton Muhin, 2013/05/14 06:17:34]

I might be overvaluing cascade syntax, but something like

drawnData.data
  ..[0] = ...
  ..[1] = ...

might be an interesting alternative.  Up to you though.

[Andrei Mouravski, 2013/05/21 09:38:49]

Not going to worry about it for now.


On 2013/05/14 06:17:34, Anton Muhin wrote:

+      drawnData.data[1] = 65;
+      drawnData.data[2] = 255;
+      drawnData.data[3] = 255;
+
+      // Draw these pixels to the 2nd pixel.
+      drawnData.data[2 * 4 + 0] = 25;
+      drawnData.data[2 * 4 + 1] = 65;
+      drawnData.data[2 * 4 + 2] = 255;
+      drawnData.data[2 * 4 + 3] = 255;
+
+      // Draw these pixels to the 8th pixel.
+      drawnData.data[7 * 4 + 0] = 25;
+      drawnData.data[7 * 4 + 1] = 65;
+      drawnData.data[7 * 4 + 2] = 255;
+      drawnData.data[7 * 4 + 3] = 255;
+
+      // Use a dirty rectangle to limit what pixels are drawn.
+      context.putImageData(drawnData, 0, 0, 1, 0, 5, 5);
+
+      // Expect the data to be all green, as we skip all drawn pixels.
+      ImageData expectedData = context.createImageData(10, 10);
+      for (int i = 0; i < expectedData.data.length; i++) {
+        switch (i % 4) {
+          case 0:
+            expectedData.data[i] =  0;
+            break;
+          case 1:
+            expectedData.data[i] =  128;
+            break;
+          case 2:
+            expectedData.data[i] =  0;
+            break;
+          case 3:
+            expectedData.data[i] =  255;
+            break;
+        }
+      }
+      // Third pixel was copied.
+      expectedData.data[2 * 4 + 0] = 25;
+      expectedData.data[2 * 4 + 1] = 65;
+      expectedData.data[2 * 4 + 2] = 255;
+      expectedData.data[2 * 4 + 3] = 255;
+
+      // Make sure that our data is all green.
+      var resultingData = context.getImageData(0, 0, 10, 10);
+      expect(resultingData.data, expectedData.data);
+    });
+
+    test('putImageData throws with wrong number of arguments', () {
+      ImageData expectedData = context.getImageData(0, 0, 10, 10);
+
+      expect(() => context.putImageData(expectedData, 0, 0, 1),
+        throwsArgumentError);
+      expect(() => context.putImageData(expectedData, 0, 0, 1, 1),
+        throwsArgumentError);
+      expect(() => context.putImageData(expectedData, 0, 0, 1, 1, 5),
+        throwsArgumentError);
+    });
   });
 
   group('arc', () {
     setUp(setupFunc);
     tearDown(tearDownFunc);
 
     test('default arc should be clockwise', () {
       context.beginPath();
       final r = 10;
 
@@ skipping 409 matching lines @@
       var imageData = context.createImageData(15, 15);
       expect(imageData.width, 15);
       expect(imageData.height, 15);
 
       var other = context.createImageDataFromImageData(imageData);
       expect(other.width, 15);
       expect(other.height, 15);
     });
   });
 }