Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1513793003: HSTS preload list: do not include subdomains for flipagram.com . (Closed)

Created:
5 years ago by lgarron
Modified:
5 years ago
Reviewers:
agl
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HSTS preload list: do not include subdomains for flipagram.com . Reason given: > Some time ago, I launched HSTS on flipagram.com and submitted it to the > preload app with the includeSubdomains property set in the header. > Unfortunately, I did not realize the full implications of including this > flag until recently. Our engineering team cannot reach many of our > internal subdomains because they are only reachable with http. BUG=527947 TBR=agl@chromium.org Committed: https://crrev.com/c144c467ae73266dfaca1ba3a846da9477000c6c Cr-Commit-Position: refs/heads/master@{#364277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1991 lines, -1988 lines) Patch
M net/http/transport_security_state_static.h View 1 chunk +1990 lines, -1987 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513793003/1
5 years ago (2015-12-09 22:09:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513793003/1
5 years ago (2015-12-09 22:14:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/108072)
5 years ago (2015-12-10 01:35:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513793003/1
5 years ago (2015-12-10 01:48:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 04:39:21 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-10 04:40:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c144c467ae73266dfaca1ba3a846da9477000c6c
Cr-Commit-Position: refs/heads/master@{#364277}

Powered by Google App Engine
This is Rietveld 408576698