Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 151373004: A64: Restore FP registers in Deoptimizer::EntryGenerator::Generate (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Restore FP registers in Deoptimizer::EntryGenerator::Generate BUG=none R=rodolph.perfetta@arm.com, ulan@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=18998

Patch Set 1 #

Total comments: 4

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1

Patch Set 4 : updates #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/a64/assembler-a64.h View 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/a64/deoptimizer-a64.cc View 1 2 3 4 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-31 14:04:51 UTC) #1
jochen (gone - plz use gerrit)
ptal
6 years, 10 months ago (2014-01-31 14:36:22 UTC) #2
ulan
lgtm
6 years, 10 months ago (2014-01-31 14:38:21 UTC) #3
Rodolph Perfetta (ARM)
https://codereview.chromium.org/151373004/diff/1/src/a64/deoptimizer-a64.cc File src/a64/deoptimizer-a64.cc (right): https://codereview.chromium.org/151373004/diff/1/src/a64/deoptimizer-a64.cc#newcode489 src/a64/deoptimizer-a64.cc:489: __ Mov(x4, x0); Pop directly into x4 and update ...
6 years, 10 months ago (2014-01-31 14:50:28 UTC) #4
jochen (gone - plz use gerrit)
ptal
6 years, 10 months ago (2014-01-31 15:11:48 UTC) #5
Rodolph Perfetta (ARM)
LGTM with nit addressed. https://codereview.chromium.org/151373004/diff/100001/src/a64/deoptimizer-a64.cc File src/a64/deoptimizer-a64.cc (right): https://codereview.chromium.org/151373004/diff/100001/src/a64/deoptimizer-a64.cc#newcode523 src/a64/deoptimizer-a64.cc:523: const FPRegister reg = saved_fp_registers.PopLowestIndex().D(); ...
6 years, 10 months ago (2014-01-31 15:35:47 UTC) #6
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-31 15:40:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r18998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698