Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1513723002: Fix bug with GrAtlasTextContext color regen (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bug with GrAtlasTextContext color regen BUG=skia: Committed: https://skia.googlesource.com/skia/+/f9e658b1d648948ebe37db5cceebd61cddc94575

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/gpu/GrAtlasTextBlob.h View 6 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/GrAtlasTextBlob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1508853005 Patch 1

Messages

Total messages: 9 (4 generated)
joshualitt
ptal
5 years ago (2015-12-09 16:35:16 UTC) #2
egdaniel
lgtm
5 years ago (2015-12-09 17:05:06 UTC) #3
egdaniel
https://codereview.chromium.org/1513723002/diff/1/src/gpu/batches/GrAtlasTextBatch.cpp File src/gpu/batches/GrAtlasTextBatch.cpp (right): https://codereview.chromium.org/1513723002/diff/1/src/gpu/batches/GrAtlasTextBatch.cpp#newcode206 src/gpu/batches/GrAtlasTextBatch.cpp:206: // We my have changed the color so update ...
5 years ago (2015-12-09 17:08:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513723002/20001
5 years ago (2015-12-09 17:13:14 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 17:26:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f9e658b1d648948ebe37db5cceebd61cddc94575

Powered by Google App Engine
This is Rietveld 408576698