Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1513713002: [cleanup] [proxies] Unify style of recently written code (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] [proxies] Unify style of recently written code In particular, return Maybe<bool> from any function that can throw, and use MAYBE_RETURN and RETURN_FAILURE macros consistently where applicable. No change in behavior intended. Committed: https://crrev.com/e94f07aa2e909410d6b7611c967106035a9d860a Cr-Commit-Position: refs/heads/master@{#32723}

Patch Set 1 #

Patch Set 2 : update forgotten comment #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -406 lines) Patch
M src/api.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/key-accumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/key-accumulator.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M src/objects.h View 1 2 5 chunks +38 lines, -44 lines 0 comments Download
M src/objects.cc View 1 2 73 chunks +298 lines, -334 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Jakob Kummerow
PTAL.
5 years ago (2015-12-09 16:00:06 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-09 16:17:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513713002/40001
5 years ago (2015-12-09 17:42:01 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-09 18:06:55 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 18:07:07 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e94f07aa2e909410d6b7611c967106035a9d860a
Cr-Commit-Position: refs/heads/master@{#32723}

Powered by Google App Engine
This is Rietveld 408576698