Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: cc/proto/compositor_message_to_impl.proto

Issue 1513643010: cc:: Add remote mode to the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresed comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/proto/compositor_message_to_impl.proto
diff --git a/cc/proto/compositor_message_to_impl.proto b/cc/proto/compositor_message_to_impl.proto
new file mode 100644
index 0000000000000000000000000000000000000000..8d173164f19b1d89fc0b81d1c94da7874dd3fdb6
--- /dev/null
+++ b/cc/proto/compositor_message_to_impl.proto
@@ -0,0 +1,55 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
vmpstr 2016/01/11 21:50:15 2016
Khushal 2016/01/13 02:07:11 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+
+import "layer_tree_settings.proto";
+
+package cc.proto;
+
+// Control messages sent to the impl side of the compositor (client) from the
+// main side of the compositor (server).
+// Note: Unless specified in a comment, all fields in a message are required,
+// even if listed as optional.
+message CompositorMessageToImpl {
+ enum Type {
+ Unknown = 0;
vmpstr 2016/01/11 21:50:15 I think we went with SHOUT_CASE for enums (https:/
Khushal 2016/01/13 02:07:12 Done.
+
+ // Client Initialization: When the remote server starts up it sends a
+ // CompositorMessageToImpl of Type::InitializeImpl to the client. This
vmpstr 2016/01/11 21:50:14 nit: s/Type::/type /
Khushal 2016/01/13 02:07:12 Done.
+ // message should be processed by the embedder of the client compositor to
+ // create the Remote Client LayerTreeHost. The compositor protocol
+ // guarantees that this will be the first message sent to the client. No
+ // messages can be sent from the client before the server is started.
+ InitializeImpl = 1;
+
+ // Client Shutdown: When the remote server is shutting down it sends a
+ // CompositorMessageToImpl of type::CloseImpl to the client. The message
+ // should be processed by the embedder of the client compositor to destroy
+ // the Remote Client LayerTreeHost. This is guaranteed to be the last
+ // message sent to the client. No messages can be sent from the client after
+ // the server has been shutdown.
+ CloseImpl = 2;
+
+ // Informs the client that a fling animation on the server has stopped.
+ MainThreadHasStoppedFlingingOnImpl = 3;
vmpstr 2016/01/11 21:50:15 Is there a corresponding start fling message? Mayb
Khushal 2016/01/13 02:07:12 Right now the message types here are basically ser
+ }
+
+ optional Type message_type = 1;
+
+ // Only one of the following fields will be set per CompositorMessageToImpl.
+
+ // Set for message Type::InitializeImpl.
+ optional InitializeImpl initialize_impl_message = 2;
+}
+
+message InitializeImpl {
+ // The embedder of the remote client compositor should process the
vmpstr 2016/01/11 21:50:15 nit: Can you move this comment before "message Ini
Khushal 2016/01/13 02:07:11 Done.
+ // InitializeImpl message to retrieve the LayerTreeSettings sent from the
+ // server.
+ // The settings sent from the server may be modified by the embedder.
vmpstr 2016/01/11 21:50:15 formatting nit: move this line to the previous one
Khushal 2016/01/13 02:07:11 Done.
+ optional LayerTreeSettings layer_tree_settings = 1;
+}

Powered by Google App Engine
This is Rietveld 408576698