Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Side by Side Diff: src/a64/builtins-a64.cc

Issue 151363004: A64: Remove two TODOs that will not be done. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/assembler-a64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 // Push the function and the receiver onto the stack. 677 // Push the function and the receiver onto the stack.
678 __ Push(function, receiver); 678 __ Push(function, receiver);
679 679
680 // Copy arguments to the stack in a loop, in reverse order. 680 // Copy arguments to the stack in a loop, in reverse order.
681 // x3: argc. 681 // x3: argc.
682 // x4: argv. 682 // x4: argv.
683 Label loop, entry; 683 Label loop, entry;
684 // Compute the copy end address. 684 // Compute the copy end address.
685 __ Add(x10, argv, Operand(argc, LSL, kPointerSizeLog2)); 685 __ Add(x10, argv, Operand(argc, LSL, kPointerSizeLog2));
686 686
687 // TODO(all): This can potentially be optimized with ldp/stp to speed up
688 // arguments passing from C++ to JS.
689 __ B(&entry); 687 __ B(&entry);
690 __ Bind(&loop); 688 __ Bind(&loop);
691 __ Ldr(x11, MemOperand(argv, kPointerSize, PostIndex)); 689 __ Ldr(x11, MemOperand(argv, kPointerSize, PostIndex));
692 __ Ldr(x12, MemOperand(x11)); // Dereference the handle. 690 __ Ldr(x12, MemOperand(x11)); // Dereference the handle.
693 __ Push(x12); // Push the argument. 691 __ Push(x12); // Push the argument.
694 __ Bind(&entry); 692 __ Bind(&entry);
695 __ Cmp(x10, argv); 693 __ Cmp(x10, argv);
696 __ B(ne, &loop); 694 __ B(ne, &loop);
697 695
698 // Initialize all JavaScript callee-saved registers, since they will be seen 696 // Initialize all JavaScript callee-saved registers, since they will be seen
(...skipping 775 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 __ Bind(&dont_adapt_arguments); 1472 __ Bind(&dont_adapt_arguments);
1475 __ Jump(x3); 1473 __ Jump(x3);
1476 } 1474 }
1477 1475
1478 1476
1479 #undef __ 1477 #undef __
1480 1478
1481 } } // namespace v8::internal 1479 } } // namespace v8::internal
1482 1480
1483 #endif // V8_TARGET_ARCH_ARM 1481 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/a64/assembler-a64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698