Chrome_Win: Renderer Crash - WebCore::FrameView::setFrameRect

Chrome_Win: Renderer Crash - WebCore::FrameView::setFrameRect

This crash is caused by r166295
ismainframe check needs to be added before using the page

BUG=340580

[gnana, 2014-02-04 13:18:13]

Please have a look

[pfeldman, 2014-02-04 18:18:35]

lgtm

[gnana, 2014-02-04 18:32:10]

The CQ bit was checked by gnanasekar.s@samsung.com

[commit-bot: I haz the power, 2014-02-04 18:32:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:41:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:42:04]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:45:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:46:01]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:48:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:48:08]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:50:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:50:09]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:51:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:51:43]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:52:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:52:17]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:53:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:53:04]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:53:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:53:46]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:55:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:55:29]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[eseidel, 2014-02-04 20:55:56]

You can also access settings via Frame::settings() or Document::settings(), we
have many wrappers like that.

Page is a embedding-level concept which is going away.  FrameHost is the
blink-side cache of page-level concepts and holds thins like Settings.

This feels odd, that FrameView needs to know anything about the inspector.  The
inspector sits on top of Blink.  I would expect the inspector to simply change
the Settings object and Blink not need to call the inspector to adjust them. :(

[commit-bot: I haz the power, 2014-02-04 20:56:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:56:45]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 20:57:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 20:57:51]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[commit-bot: I haz the power, 2014-02-04 22:23:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/151363003/1

[commit-bot: I haz the power, 2014-02-04 22:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 22:23:35]

Failed to apply patch for Source/core/frame/FrameView.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/FrameView.cpp
  Hunk #1 FAILED at 379.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/FrameView.cpp.rej

Patch:       Source/core/frame/FrameView.cpp
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index
4bf08a4e79bb04b5f000e42c22ce68c24262bf4d..4820c319e34448e46e21b79ef703341fff09be8b
100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -379,13 +379,15 @@ void FrameView::setFrameRect(const IntRect& newRect)
 
     // Autosized font sizes depend on the width of the viewing area.
     if (newRect.width() != oldRect.width()) {
-        Page* page = m_frame->page();
-        bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
-        if (isMainFrame() && textAutosizingEnabled) {
-            TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
-            if (textAutosizer) {
-                for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            Page* page = m_frame->page();
+            bool textAutosizingEnabled =
InspectorInstrumentation::overrideTextAutosizing(page,
page->settings().textAutosizingEnabled());
+            if (textAutosizingEnabled) {
+                TextAutosizer* textAutosizer =
m_frame->document()->textAutosizer();
+                if (textAutosizer) {
+                    for (Frame* frame = page->mainFrame(); frame; frame =
frame->tree().traverseNext())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }

[pfeldman, 2014-02-05 05:48:13]

>> This feels odd, that FrameView needs to know anything about the inspector. 
The
>> inspector sits on top of Blink.  I would expect the inspector to simply
change
>> the Settings object and Blink not need to call the inspector to adjust them.
:(

@eseidel: https://codereview.chromium.org/146683003/#msg6 explains why this is
necessary. In this case, inspector is not configuring the running page, it is
rather overriding the settings passed by the embedder. It is not common for
inspector and is only used in the code paths related to mobile emulation.

Given the OOP iframes context of the conversation though, note, that call sites
don't need to resolve to the page, it should look like this instead:

bool textAutosizingEnabled =
InspectorInstrumentation::overridenTextAutosizing(frame);

Today, inspector will resolve to the page to fetch overrides from the page
agents on its own. But as OOP iframes emerge, we will be able to locally migrate
to the new way of resolving agents for frames. I'll follow up with the patch
that removes frame->page transitions in these overrides.

[pfeldman, 2014-02-05 06:35:47]

@eseidel: to make inspector sit on top of Blink for overrides as well, we could
intercept WebSettingsImpl::setTextAutosizingEnabled and
WebSettingsImpl::setDeviceScaleAdjustment to make them go through the
InspectorController. After reading your comment twice, I think you would prefer
this option. I'll follow up :)