Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1513573013: Don't call LayoutPart::widgetPositionsUpdated unnecessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 // compositing state, and remove this disabler. 347 // compositing state, and remove this disabler.
348 DisableCompositingQueryAsserts disabler; 348 DisableCompositingQueryAsserts disabler;
349 349
350 // Update the positions of our child layers (if needed as only fixed layers should be impacted by a scroll). 350 // Update the positions of our child layers (if needed as only fixed layers should be impacted by a scroll).
351 // We don't update compositing layers, because we need to do a deep update f rom the compositing ancestor. 351 // We don't update compositing layers, because we need to do a deep update f rom the compositing ancestor.
352 if (!frameView->isInPerformLayout()) { 352 if (!frameView->isInPerformLayout()) {
353 // If we're in the middle of layout, we'll just update layers once layou t has finished. 353 // If we're in the middle of layout, we'll just update layers once layou t has finished.
354 layer()->updateLayerPositionsAfterOverflowScroll(scrollDelta); 354 layer()->updateLayerPositionsAfterOverflowScroll(scrollDelta);
355 // Update regions, scrolling may change the clip of a particular region. 355 // Update regions, scrolling may change the clip of a particular region.
356 frameView->updateDocumentAnnotatedRegions(); 356 frameView->updateDocumentAnnotatedRegions();
357 frameView->setNeedsUpdateWidgetPositions(); 357 frameView->setNeedsUpdateWidgetGeometries();
358 updateCompositingLayersAfterScroll(); 358 updateCompositingLayersAfterScroll();
359 } 359 }
360 360
361 const LayoutBoxModelObject& paintInvalidationContainer = box().containerForP aintInvalidation(); 361 const LayoutBoxModelObject& paintInvalidationContainer = box().containerForP aintInvalidation();
362 // The caret rect needs to be invalidated after scrolling 362 // The caret rect needs to be invalidated after scrolling
363 frame->selection().setCaretRectNeedsUpdate(); 363 frame->selection().setCaretRectNeedsUpdate();
364 364
365 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(layer()->layoutObj ect()->previousPaintInvalidationRectIncludingCompositedScrolling(paintInvalidati onContainer))); 365 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(layer()->layoutObj ect()->previousPaintInvalidationRectIncludingCompositedScrolling(paintInvalidati onContainer)));
366 366
367 quadForFakeMouseMoveEvent = paintInvalidationContainer.localToAbsoluteQuad(q uadForFakeMouseMoveEvent); 367 quadForFakeMouseMoveEvent = paintInvalidationContainer.localToAbsoluteQuad(q uadForFakeMouseMoveEvent);
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1526 } 1526 }
1527 1527
1528 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager) 1528 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
1529 { 1529 {
1530 visitor->trace(m_scrollableArea); 1530 visitor->trace(m_scrollableArea);
1531 visitor->trace(m_hBar); 1531 visitor->trace(m_hBar);
1532 visitor->trace(m_vBar); 1532 visitor->trace(m_vBar);
1533 } 1533 }
1534 1534
1535 } // namespace blink 1535 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutPart.cpp ('k') | third_party/WebKit/Source/platform/Widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698