Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1513573009:
Add check for highp support in Conic effect (Closed)
|
Created:
5 years ago by robertphillips Modified:
5 years ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779, skia:4668
TBR=bsalomon@google.com
Committed: https://skia.googlesource.com/skia/+/2eb1009b6e244dae6374dc009dc867a32f40236e
Patch Set 1 #
Messages
Total messages: 33 (25 generated)
Description was changed from
==========
Add check for highp support in Conic effect
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android One's we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High
A1 (Cherry One - Mali 400)
N5 (Adreno 330)
N6 (Adreno 420)
N7v2 (Adreno 320)
BUG=skia:555779
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android One's we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High
A1 (Cherry One - Mali 400)
N5 (Adreno 330)
N6 (Adreno 420)
N7v2 (Adreno 320)
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android One's we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
robertphillips@google.com changed reviewers: + bsalomon@google.com, egdaniel@google.com
Description was changed from
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android One's we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android One's we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android One's we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android Ones we have fall
back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL isn't really necessary since it seems that the Android Ones we have fall
back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL may not really necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - circle looks bad
N5 (Adreno 330) 10 10 23 High - circle looks bad
N6 (Adreno 420) 10 10 23 High - circle looks good
N7v2 (Adreno 320) 10 10 23 High - circle looks bad
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conics looks bad
N5 (Adreno 330) 10 10 23 High - conics looks bad
N6 (Adreno 420) 10 10 23 High - conics looks good
N7v2 (Adreno 320) 10 10 23 High - conics looks bad
BUG=skia:555779
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conics looks bad
N5 (Adreno 330) 10 10 23 High - conics looks bad
N6 (Adreno 420) 10 10 23 High - conics looks good
N7v2 (Adreno 320) 10 10 23 High - conics looks bad
BUG=skia:555779
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conics looks bad
N5 (Adreno 330) 10 10 23 High - conics looks bad
N6 (Adreno 420) 10 10 23 High - conics looks good
N7v2 (Adreno 320) 10 10 23 High - conics looks bad
BUG=skia:555779,skia:4668
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conics looks bad
N5 (Adreno 330) 10 10 23 High - conics looks bad
N6 (Adreno 420) 10 10 23 High - conics looks good
N7v2 (Adreno 320) 10 10 23 High - conics looks bad
BUG=skia:555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conics looks bad
N5 (Adreno 330) 10 10 23 High - conics looks bad
N6 (Adreno 420) 10 10 23 High - conics looks good
N7v2 (Adreno 320) 10 10 23 High - conics looks bad
BUG=555779,skia:4668
==========
lgtm
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conics looks bad
N5 (Adreno 330) 10 10 23 High - conics looks bad
N6 (Adreno 420) 10 10 23 High - conics looks good
N7v2 (Adreno 320) 10 10 23 High - conics looks bad
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
BUG=555779,skia:4668
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
BUG=555779,skia:4668
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
BUG=555779,skia:4668
==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513573009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513573009/1
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 4*s.
BUG=555779,skia:4668
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 4*s.
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 4*s.
BUG=555779,skia:4668
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits of precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 4*s.
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 4*s.
BUG=555779,skia:4668
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 4*s.
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513573009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513573009/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
TBR=bsalomon@google.com
==========
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
TBR=bsalomon@google.com
==========
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513573009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513573009/1
Message was sent while issue was closed.
Description was changed from
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
TBR=bsalomon@google.com
==========
to
==========
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have
fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
TBR=bsalomon@google.com
Committed:
https://skia.googlesource.com/skia/+/2eb1009b6e244dae6374dc009dc867a32f40236e
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2eb1009b6e244dae6374dc009dc867a32f40236e |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
