Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: minidump/minidump_crashpad_info_writer.cc

Issue 1513573005: Provide std::move() in compat instead of using crashpad::move() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « handler/mac/exception_handler_server.cc ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_crashpad_info_writer.h" 15 #include "minidump/minidump_crashpad_info_writer.h"
16 16
17 #include <utility>
18
17 #include "base/logging.h" 19 #include "base/logging.h"
18 #include "minidump/minidump_module_crashpad_info_writer.h" 20 #include "minidump/minidump_module_crashpad_info_writer.h"
19 #include "minidump/minidump_simple_string_dictionary_writer.h" 21 #include "minidump/minidump_simple_string_dictionary_writer.h"
20 #include "snapshot/process_snapshot.h" 22 #include "snapshot/process_snapshot.h"
21 #include "util/file/file_writer.h" 23 #include "util/file/file_writer.h"
22 #include "util/stdlib/move.h"
23 24
24 namespace crashpad { 25 namespace crashpad {
25 26
26 MinidumpCrashpadInfoWriter::MinidumpCrashpadInfoWriter() 27 MinidumpCrashpadInfoWriter::MinidumpCrashpadInfoWriter()
27 : MinidumpStreamWriter(), 28 : MinidumpStreamWriter(),
28 crashpad_info_(), 29 crashpad_info_(),
29 simple_annotations_(nullptr), 30 simple_annotations_(nullptr),
30 module_list_(nullptr) { 31 module_list_(nullptr) {
31 crashpad_info_.version = MinidumpCrashpadInfo::kVersion; 32 crashpad_info_.version = MinidumpCrashpadInfo::kVersion;
32 } 33 }
(...skipping 12 matching lines...) Expand all
45 46
46 UUID client_id; 47 UUID client_id;
47 process_snapshot->ClientID(&client_id); 48 process_snapshot->ClientID(&client_id);
48 SetClientID(client_id); 49 SetClientID(client_id);
49 50
50 auto simple_annotations = 51 auto simple_annotations =
51 make_scoped_ptr(new MinidumpSimpleStringDictionaryWriter()); 52 make_scoped_ptr(new MinidumpSimpleStringDictionaryWriter());
52 simple_annotations->InitializeFromMap( 53 simple_annotations->InitializeFromMap(
53 process_snapshot->AnnotationsSimpleMap()); 54 process_snapshot->AnnotationsSimpleMap());
54 if (simple_annotations->IsUseful()) { 55 if (simple_annotations->IsUseful()) {
55 SetSimpleAnnotations(crashpad::move(simple_annotations)); 56 SetSimpleAnnotations(std::move(simple_annotations));
56 } 57 }
57 58
58 auto modules = make_scoped_ptr(new MinidumpModuleCrashpadInfoListWriter()); 59 auto modules = make_scoped_ptr(new MinidumpModuleCrashpadInfoListWriter());
59 modules->InitializeFromSnapshot(process_snapshot->Modules()); 60 modules->InitializeFromSnapshot(process_snapshot->Modules());
60 61
61 if (modules->IsUseful()) { 62 if (modules->IsUseful()) {
62 SetModuleList(crashpad::move(modules)); 63 SetModuleList(std::move(modules));
63 } 64 }
64 } 65 }
65 66
66 void MinidumpCrashpadInfoWriter::SetReportID(const UUID& report_id) { 67 void MinidumpCrashpadInfoWriter::SetReportID(const UUID& report_id) {
67 DCHECK_EQ(state(), kStateMutable); 68 DCHECK_EQ(state(), kStateMutable);
68 69
69 crashpad_info_.report_id = report_id; 70 crashpad_info_.report_id = report_id;
70 } 71 }
71 72
72 void MinidumpCrashpadInfoWriter::SetClientID(const UUID& client_id) { 73 void MinidumpCrashpadInfoWriter::SetClientID(const UUID& client_id) {
73 DCHECK_EQ(state(), kStateMutable); 74 DCHECK_EQ(state(), kStateMutable);
74 75
75 crashpad_info_.client_id = client_id; 76 crashpad_info_.client_id = client_id;
76 } 77 }
77 78
78 void MinidumpCrashpadInfoWriter::SetSimpleAnnotations( 79 void MinidumpCrashpadInfoWriter::SetSimpleAnnotations(
79 scoped_ptr<MinidumpSimpleStringDictionaryWriter> simple_annotations) { 80 scoped_ptr<MinidumpSimpleStringDictionaryWriter> simple_annotations) {
80 DCHECK_EQ(state(), kStateMutable); 81 DCHECK_EQ(state(), kStateMutable);
81 82
82 simple_annotations_ = crashpad::move(simple_annotations); 83 simple_annotations_ = std::move(simple_annotations);
83 } 84 }
84 85
85 void MinidumpCrashpadInfoWriter::SetModuleList( 86 void MinidumpCrashpadInfoWriter::SetModuleList(
86 scoped_ptr<MinidumpModuleCrashpadInfoListWriter> module_list) { 87 scoped_ptr<MinidumpModuleCrashpadInfoListWriter> module_list) {
87 DCHECK_EQ(state(), kStateMutable); 88 DCHECK_EQ(state(), kStateMutable);
88 89
89 module_list_ = crashpad::move(module_list); 90 module_list_ = std::move(module_list);
90 } 91 }
91 92
92 bool MinidumpCrashpadInfoWriter::Freeze() { 93 bool MinidumpCrashpadInfoWriter::Freeze() {
93 DCHECK_EQ(state(), kStateMutable); 94 DCHECK_EQ(state(), kStateMutable);
94 95
95 if (!MinidumpStreamWriter::Freeze()) { 96 if (!MinidumpStreamWriter::Freeze()) {
96 return false; 97 return false;
97 } 98 }
98 99
99 if (simple_annotations_) { 100 if (simple_annotations_) {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 } 140 }
140 141
141 bool MinidumpCrashpadInfoWriter::IsUseful() const { 142 bool MinidumpCrashpadInfoWriter::IsUseful() const {
142 return crashpad_info_.report_id != UUID() || 143 return crashpad_info_.report_id != UUID() ||
143 crashpad_info_.client_id != UUID() || 144 crashpad_info_.client_id != UUID() ||
144 simple_annotations_ || 145 simple_annotations_ ||
145 module_list_; 146 module_list_;
146 } 147 }
147 148
148 } // namespace crashpad 149 } // namespace crashpad
OLDNEW
« no previous file with comments | « handler/mac/exception_handler_server.cc ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698