Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1513553003: Fix notifications selection when there is not task. (Closed)

Created:
5 years ago by qsr
Modified:
5 years ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix notifications selection when there is not task. When there is not task, or the task that was up when the notification service was created is finished, the notification service should not crash. R=etiennej@chromium.org BUG=Fixes https://github.com/domokit/mojo/issues/584 Committed: https://chromium.googlesource.com/external/mojo/+/92c00359a099efc4c19cf3e0c6b0ed0c43965d8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M services/notifications/src/org/chromium/mojo/notifications/NotificationServiceImpl.java View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
qsr
5 years ago (2015-12-09 09:01:51 UTC) #1
etiennej
lgtm
5 years ago (2015-12-09 09:08:34 UTC) #2
qsr
5 years ago (2015-12-09 12:05:06 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
92c00359a099efc4c19cf3e0c6b0ed0c43965d8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698