test/unittests/compiler/diamond-unittest.cc - Issue 1513543003: [turbofan] Make MachineType a pair of enums.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/diamond-unittest.cc

Issue 1513543003: [turbofan] Make MachineType a pair of enums. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Moar rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/diamond-unittest.cc

diff --git a/test/unittests/compiler/diamond-unittest.cc b/test/unittests/compiler/diamond-unittest.cc

index 50c50d4e696093f93997f2dd7672b2721a46d383..5b28a001ef917dd58f633f4b1104d811b69e0f22 100644

--- a/test/unittests/compiler/diamond-unittest.cc

+++ b/test/unittests/compiler/diamond-unittest.cc

@@ -114,7 +114,8 @@ TEST_F(DiamondTest, DiamondPhis) {

Node* p2 = Parameter(2);

Diamond d(graph(), common(), p0);

- MachineType types[] = {kMachAnyTagged, kMachUint32, kMachInt32};

+ MachineRepresentation types[] = {MachineRepresentation::kTagged,

+ MachineRepresentation::kWord32};

for (size_t i = 0; i < arraysize(types); i++) {

Node* phi = d.Phi(types[i], p1, p2);